don't know exactly but this is what MarkupContainer is saying:

public void internalBeginRequest()
   {
       // Handle begin request for the container itself
       super.internalBeginRequest();

       // Loop through child components
for (final Iterator iterator = childForId.values().iterator(); iterator.hasNext();)
       {
           Component child = (Component)iterator.next();
if (!(child instanceof IFeedback)) // ignore feedback as that was done in Page <<<<<<<<<<<<<<<<<
           {
               // Call begin request on the child
               (child).internalBeginRequest();
           }
       }

So here all childs that implements IFeedback are not processed..
So if you remove that line then childs that implements IFeedback won't get an internalBeginRequest() anymore..

johan


Jonathan Locke wrote:

unit tests pass and feedback seems to work in forms i've tried.

i made a little last minute change and removed the indicated line below:

               visitChildren(IFeedback.class, new IVisitor()
               {
                   public Object component(Component component)
                   {
                       ((IFeedback)component).updateFeedback();
>>>>>                   component.internalBeginRequest();
                       return IVisitor.CONTINUE_TRAVERSAL;
                   }
               });

this looks from the code to be completely innocuous. but the effect is all hell breaking loose! the new updateFeedback() method call should have been enough. does anyone on the dev list have any idea why this internalBeginRequest() method needs to be called here?

thanks!

         jon




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to