Honestly I'd prefer to disallow setName() as well. IMO it is bad style to do it in first place. Why not have two tags, one for label and one for images which get enabled/disabled (setVisible) on business logic.
Juergen ---------- Forwarded message ---------- From: SourceForge.net <[EMAIL PROTECTED]> Date: Sep 7, 2005 1:03 PM Subject: [Wicket-develop] [ wicket-Bugs-1283807 ] ComponentTag.setType should be in public API To: [EMAIL PROTECTED] Bugs item #1283807, was opened at 2005-09-07 12:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1283807&group_id=119783 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: javadoc Group: 1.1 Status: Open Resolution: None Priority: 5 Submitted By: Simon Berriman (sberriman) Assigned to: Nobody/Anonymous (nobody) Summary: ComponentTag.setType should be in public API Initial Comment: ComponentTag.setType(Type) is currently documented as not being part of the public API. However, if you can change the name of a tag, then you should be allowed to change its type too. My instance is having markup such as : <span wicket:id="dataItem">dataItem</span> in a Loop, which, most of the time displays textual output via a Label. However, if I want to convert the span to an Image, it is possible with a subclass of Image, but only be calling setType in the overridden onRender(). If you're worried about the necessary referenence to the XmlTag Types, then they could be echoed in ComponentTag. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1283807&group_id=119783 ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
