we now do this:

if (!Strings.isEmpty(button.getInput())
                        || !Strings.isEmpty(getRequest().getParameter(button.getInputName() + ".x")))

To check if the button is pressed (looking if the value is set in the request)
But i have buttons that don't have a value (but a background css image)
So that button is in the request but with a "" and currently null == ""
but that is not the same i think
A button that isn't pressed will return null
But a button that is pressed can also return "" or an other string.

so i changed it to:

                if (getRequest().getParameter(button.getInputName()) != null
                        || getRequest().getParameter(button.getInputName() + ".x") != null)

so purely a test on null.
I think this should always work or don't i see something quite right?              

Reply via email to