What about some other pattern than just a factory method? Any of the other devs care for this discussion?
Eelco On 12/19/05, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > > What happens if somebody build on top of my application class? And wants > to > > > do there own WenRequestEncoder() ? > > > Then suddenly it has to copy MY part of the default request processor > and > > > add theres. But that will not happen > > > i think i loose my Exception processor because he just override the > default > > > wickets and only change the webrequest encoder. > > > > Yeah, now *that's* a good question. Excactly. onRuntimeException will > > not be called! How much does that suck?! That's my whole point of why > > I don't think it should be in there. > > > Ahh yes Exactly right! I have implemenented my own > DefaultExceptionResponseProcessor in my application object > And i had to do this by overriding the IRequestCycleProcessor > getDefaultRequestCycleProcessor() so now i have my neath > exeption handler. But then suddenly somebody extends my application object > and he wants its own Encoder and also overrides > IRequestCycleProcessor getDefaultRequestCycleProcessor(). > HEE suddenly i loose Mine. > > So it is exactly the same!! Youre argument is exactly what i was constantly > talking about. > You should never need to override One method that does X number of things to > do really override one thing!! > > I agree that maybe it is better that we don't have that onException method > inside Application. Fine by me > But not in the solution where you have to override completely something else > at the first place to gain it. > > johan > > > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
