yup.  seems good.  and ironically, this is how it was originally...

Igor Vaynberg wrote:
but there is already an api break with getRequiredPageSettings()
so we substitute this one for that one, at the end we only have a single api break and a cleaner, more expressive application class

-Igor


On 1/4/06, *Martijn Dashorst* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:

    It is again an API break... :-(

    Martijn

    On 1/4/06, Igor Vaynberg <[EMAIL PROTECTED]
    <mailto:[EMAIL PROTECTED]>> wrote:
    > seems the best solution irt the homepage is to make it abstract
    method of
    > the application.
    >
    > so i am committing
    >
    > public abstract Class Application.getHomePage()
    >
    > this makes sense because the application cannot run without a
    homepage so it
    > should force the user to provide it.
    >
    > is anyone opposed?
    >
    > -Igor
    >
    >
    >
    > On 1/4/06, Jonathan Locke <[EMAIL PROTECTED]
    <mailto:[EMAIL PROTECTED]> > wrote:
    > >
    > > it's not really a setting regarding pages though.  it's an app
    setting.
    > > maybe these particular methods should be on the Application
    object itself?
    > >
    > > one idea i might like better:
    > >
    > >     move get/setHomePage to Application (very obvious for
    beginners)
    > >     then create IErrorPageSettings and put the two error page
    class
    > > properties in there.
    > >     delete IRequiredPageSettings
    > >
    > > Igor Vaynberg wrote:
    > > > should we merge getRequiredPageSettings() into
    getPageSettings()?
    > > >
    > > > -Igor
    > > >
    > >
    > >
    > > -------------------------------------------------------
    > > This SF.net email is sponsored by: Splunk Inc. Do you grep
    through log
    > files
    > > for problems?  Stop!  Download the new AJAX search engine that
    makes
    > > searching your log files as easy as surfing
    the  web.  DOWNLOAD SPLUNK!
    > > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
    <http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click>
    > > _______________________________________________
    > > Wicket-develop mailing list
    > > [email protected]
    <mailto:[email protected]>
    > >
    > https://lists.sourceforge.net/lists/listinfo/wicket-develop
    > >
    >
    >


    --
    Living a wicket life...

    Martijn Dashorst - http://www.jroller.com/page/dashorst

    Wicket 1.1 is out: http://wicket.sourceforge.net/wicket-1.1


    -------------------------------------------------------
    This SF.net email is sponsored by: Splunk Inc. Do you grep through
    log files
    for problems?  Stop!  Download the new AJAX search engine that makes
    searching your log files as easy as surfing the  web.  DOWNLOAD
    SPLUNK!
    http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
    <http://ads.osdn.com/?ad_idv37&alloc_id%16865&opclick>
    _______________________________________________
    Wicket-develop mailing list
    [email protected]
    <mailto:[email protected]>
    https://lists.sourceforge.net/lists/listinfo/wicket-develop
    <https://lists.sourceforge.net/lists/listinfo/wicket-develop>




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to