Johan there is one more: AbstractResourceStreamLoader and ResourceStreamLoader seem to be redundant. Looks like I didn't finished some refactoring. I guess ResourceStreamLoader seems to be more or less obsolete/redundant
Juergen On 1/19/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > On 1/19/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > > I think i agree with Matej on this one > > (have already made some refactorings.) > > > > But just to make sure. > > > > Settings.getResourceLocator() should return an instance and not a > > implemenation. > > > > why? why do we the interface than? > > > Then is it a bad thing that we change the interface from: > > > > public IResourceStream locate(ClassLoader classLoader, String path, String > > style, Locale locale, String extension); > > > > to > > > > public IResourceStream locate(Class class, String path, String style, Locale > > locale, String extension); > > > > I don't remember a specific reason why it is classloader and not class > either. So +1 for the change. > > Juergen > > > So that you have a bit more info in the Locator? > > I think this should work fine because we in wicket do class.getClassLoader() > > pretty much everwhere where we call that interface method. > > And we do have 2 places where we call the ResourceStreamLocator method > > itself (so we aren't even using the interface method which is bad) > > > > johan > > > > > > > > On 1/19/06, Matej Knopp <[EMAIL PROTECTED]> wrote: > > > Would it be possible to make IResourceStreamLocator.locate take class > > > instead of class loader? > > > > > > And is it all right that > > ResourceSettings.setResourceStreamLocator takes > > > class (ResourceStreamLocator) instead of an interface? > > > > > > -Matej > > > > > > > > > ------------------------------------------------------- > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log > > files > > > for problems? Stop! Download the new AJAX search engine that makes > > > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 > > > _______________________________________________ > > > Wicket-develop mailing list > > > Wicket-develop@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
