Feature Requests item #1411439, was opened at 2006-01-21 11:23 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1411439&group_id=119783
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: None Status: Open Priority: 5 Submitted By: Juergen Donnerstag (jdonnerstag) Assigned to: Nobody/Anonymous (nobody) Summary: AjaxHandler misused for initialization Initial Comment: IHeaderContributor is an interface to be implemented by components which intend to contribute to the <head> section of a page. The original intend was that only Panel and Border require to implement IHeaderContributor, but to save coded duplication I moved the code into WebMarkupContainer because it is a common subclass for Panel and Border. WebMarkupContainer did NOT implement IHeaderContributor though. Only Panel and Border did. Thus the number of components in the component hierarchy were limited to a few (=> efficient). If anyone wanted his component to contribute to the header as well, he simply would have to implement IHeaderContributor. Currently, because we felt that AjaxHandler should allow to contribute to headers as well, ALL WebMarkupContainer and ALL WebComponent implement IHeaderContributor in order to forward the request to the AjaxHandlers registered with any component. IMO this is not necessary and it could save us some code, improve code clarity and improve the performance if we agree on removing it. Currently we do add(new DojoAjaxHandler()) to add the required (dojo etc) javascript links to the header. That of course can not be much easier. Using the IHeaderContributor it would be like public class DojoTextField implements IHeaderContributor { public void renderHead(final HtmlHeaderContainer container) { Dojo.addHeaderMarkup(container); } } IMO that is an acceptable amount of extra code, beside that I think it make it more obvious what is happing. The same story goes for IBodyOnLoadContributor Juergen ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1411439&group_id=119783 ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop