Would that really help much? It would introduce unclarity too:
public static final Action ENABLE_STRING = "ENABLE";
public static final Action ENABLE = new Action(ENABLE_STRING);
And then my initial idea where I wanted to use just simple strings...
that has some advantages as we can see now.
I think we should just document what strings are available by default
and leave it with that.
Eelco
On 2/10/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> wherever the action classes are declared i would imagine, in Component?
>
> -Igor
>
>
>
> On 2/10/06, Eelco Hillenius < [EMAIL PROTECTED]> wrote:
> >
> > You don't like magical strings? ;) Where should we put the two constants?
> >
> > Eelco
> >
> >
> > On 2/10/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > > so lets at least define the string constant for action names
> > >
> > > -Igor
> > >
> > >
> > >
> > > On 2/10/06, Eelco Hillenius < [EMAIL PROTECTED]> wrote:
> > > >
> > > > @AuthorizedAction(Component.RENDER, blah) would be nice, but how are
> > > > you going to do that with annotations? You need to either use one of
> > > > the basic types, and enum or another annotation. I thought about
> > > > enums, but that would limit people too much as they are not
> > > > extensible.
> > > >
> > > > Eelco
> > > >
> > > >
> > > > On 2/10/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > > > > how exactly is it more verbose?
> > > > >
> > > > > @AuthorizedAction(Component.RENDER , blah)
> > > > >
> > > > > instead of AuthorizedAction("RENDER", blah)
> > > > >
> > > > > then we get into case sensitve issues "Render", "render", "RENDER"
> > > > >
> > > > > if taking action is really bad, then lets define the action names in
> > > > > component so users can use constants
> > > > >
> > > > > public static final RENDER_NAME="RENDER" or wahtever name we choose.
> > > > >
> > > > > -Igor
> > > > >
> > > > >
> > > > >
> > > > > On 2/10/06, Eelco Hillenius < [EMAIL PROTECTED]> wrote:
> > > > > >
> > > > > > I considered this, but using Action instead of a String would make
> > > > > > using these annotations even more verbose than they currently are.
> > > > > > However, let's see what other people think of this...
> > > > > >
> > > > > > Yes, that's a request for your opinion, reader :)
> > > > > >
> > > > > > Eelco
> > > > > >
> > > > > > On 2/10/06, SourceForge.net <[EMAIL PROTECTED]> wrote:
> > > > > > > Feature Requests item #1429375, was opened at 2006-02-10 15:03
> > > > > > > Message generated for change (Tracker Item Submitted) made by
> Item
> > > > > Submitter
> > > > > > > You can respond by visiting:
> > > > > > >
> > > > >
> > >
> https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1429375&group_id=119783
> > > > > > >
> > > > > > > Please note that this message will contain a full copy of the
> > > comment
> > > > > thread,
> > > > > > > including the initial issue submission, for this request,
> > > > > > > not just the latest update.
> > > > > > > Category: None
> > > > > > > Group: 1.2
> > > > > > > Status: Open
> > > > > > > Priority: 5
> > > > > > > Submitted By: Philip A. Chapman (theserge)
> > > > > > > Assigned to: Nobody/Anonymous (nobody)
> > > > > > > Summary: Uniformity for Annotation action values
> > > > > > >
> > > > > > > Initial Comment:
> > > > > > > Currently, the @AuthorizedAction and @AuthorizedActions
> > > > > > > take String values for the action parameter. Anyone
> > > > > > > wanting to use the annotations have to know what
> > > > > > > strings can be used. Currently, there are no set of
> > > > > > > constants that indicates what values are
> > > > > > > available/correct (AFAIK based on the examples project).
> > > > > > >
> > > > > > > It would be very nice if this would take a
> > > > > > > wicket.authorization.Action instead of a String so that
> > > > > > > one could use Component.ENABLE, Component.RENDER, etc.
> > > > > > > to define what actions are available. What actions are
> > > > > > > available would be much easier to know and easier to
> > > > > > > express.
> > > > > > >
> > > > > > >
> > > > >
> > >
> ----------------------------------------------------------------------
> > > > > > >
> > > > > > > You can respond by visiting:
> > > > > > >
> > > > >
> > >
> https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1429375&group_id=119783
> > > > > > >
> > > > > > >
> > > > > > >
> > > -------------------------------------------------------
> > > > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep
> through
> > > log
> > > > > files
> > > > > > > for problems? Stop! Download the new AJAX search engine that
> makes
> > > > > > > searching your log files as easy as surfing the web. DOWNLOAD
> > > SPLUNK!
> > > > > > >
> > > > >
> > >
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> > > > > > > _______________________________________________
> > > > > > > Wicket-develop mailing list
> > > > > > > Wicket-develop@lists.sourceforge.net
> > > > > > >
> > > > >
> > >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > -------------------------------------------------------
> > > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through
> log
> > > > > files
> > > > > > for problems? Stop! Download the new AJAX search engine that
> makes
> > > > > > searching your log files as easy as surfing the web. DOWNLOAD
> > > SPLUNK!
> > > > > >
> > > > >
> > >
> http://sel.as-us.falkag.net/sel?cmdlnk&kid3432&bid#0486&dat1642
> > > > > > _______________________________________________
> > > > > > Wicket-develop mailing list
> > > > > > Wicket-develop@lists.sourceforge.net
> > > > > >
> > > > >
> > >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> -------------------------------------------------------
> > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> > > files
> > > > for problems? Stop! Download the new AJAX search engine that makes
> > > > searching your log files as easy as surfing the web. DOWNLOAD
> SPLUNK!
> > > >
> > >
> http://sel.as-us.falkag.net/sel?cmdlnk&kid3432&bid#0486&dat1642
> > > > _______________________________________________
> > > > Wicket-develop mailing list
> > > > Wicket-develop@lists.sourceforge.net
> > > >
> > >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> > > >
> > >
> > >
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> files
> > for problems? Stop! Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> >
> http://sel.as-us.falkag.net/sel?cmdlnk&kid3432&bid#0486&dat1642
> > _______________________________________________
> > Wicket-develop mailing list
> > Wicket-develop@lists.sourceforge.net
> >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >
>
>
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
