+1 On 3/20/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > if unit test are ok and the listview still works (most likely to be affected > by this) > then +1 > > johan > > > > On 3/20/06, Martijn Dashorst < [EMAIL PROTECTED]> wrote: > > > > > > > > I've got a last minute fix for this bug that I'd like to include. Your > thoughts and your vote are desired. > > > > Best, > > > > Jon > > > > The change: > > > > New methods onAttach(), onDetach(), onBeginRender() and onEndRender() have > been introduced. onAttach() and onDetach() are called in > internalOnBegin/EndRequest() so they should have the same semantics as the > code that is currently doing attach/detach stuff in those places. In Wicket > 1.3, we can tighten that up further. > > > > In order to guarantee that calls to onBeginRender() and onEndRender() > occur in all cases, i renamed Component.doRender() -> > Component.renderComponent() and Page.doRender() -> renderPage so that i > could make each one final. The renderComponent() method preserves the > earlier doRender semantics exactly by checking for instanceof Page and > calling Page.renderPage() in that case as if it were overridden. > > > > The result is that we can deprecate Component.onBegin/EndRequest() now and > provide alternatives for both former usages that will be easy to tighten up > or modify in Wicket 1.3 or in the future. I also changed all internal uses > of doRender() and onBegin/EndRequest() to the appropriate method. > > > > > > Please vote for this issue as soon as possible. > > > > Martijn > > > > > > -- > > Cast your final vote for Wicket in the SourceForge.net 2006 Community > Choice Awards! > > > http://www.wilsonresearch.com/2006/ostgawards06/ostgawards4.php > >
------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
