Feature Requests item #1462404, was opened at 2006-03-31 22:55 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1462404&group_id=119783
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: 1.3 Status: Open Priority: 5 Submitted By: Jesper Preuss (fluxcoder) Assigned to: Nobody/Anonymous (nobody) Summary: Change Link hierarchy Initial Comment: I suggest that the link hierarki is changed. The superclass is at the moment Link that implements ILinkListener. Most of the wicket links extends Link, like BookmarkablePage. But ExternalLink does not, because it would then implement ILinkListener and other method it would not need (bloatware). But still it would be nice if all links in wicket would implement or extends the same Link class. For the discussion about this see http://sourceforge.net/mailarchive/forum.php?thread_id=10082311&forum_id=42411 or http://thread.gmane.org/gmane.comp.java.wicket.user/10814 Alle links should inherit from the same link class/interface, because they have identical fundamental characteristicts; like a target, labelName (linkName) and popupsettings. BookmarkablePage has some problems like it has a method onClick() that is never used. From the javadoc "THIS METHOD IS NOT USED!". So I propose to rewrite the inheritance hierarchy, maybe like this (Too much inheritance here): ILink /\ || AbstractLink /\ || Link /\ || LinkListen (implements ILinkListener) The link class should also be rewritten, so it only contains methods that makes sense for all it's subclasses. It would also eliminate the need for the single classes to reimplement methods that more logically should be implemented in the Link class. And all links should have a label, not just the ExternalLink. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1462404&group_id=119783 ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
