Re: [Wicket-develop] Change AbstractChoice.getChoices() to throw a NPE if the choices are null?

[Alexei Sokolov]

Code like this? from AbstractChoice: final Object choice = choices.get(index);
It can be refactored to use iterator, because it is used withing for loop.
The only problem I could find is this, but it also can be refactored:

    public final String getModelValue()
    {
        final Object object = getModelObject();
        if (object != null)
        {
            int index = getChoices(). indexOf(object);
            return getChoiceRenderer().getIdValue(object, index);
        }
        return NO_SELECTION_VALUE;
    }

You guys should know the code better, so I could miss something.

Alex

On 5/10/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:

Afraid this wont be as easy because the choice objects utilize the index property of the list. Maybe in 2.0 we can refactor to work with a collection if possible.

-Igor

On 5/10/06, Alexei Sokolov <[EMAIL PROTECTED]> wrote:

One more proposed change. Replace java.util.List with more generic java.util.Collection?

Alex