Okay, it's in. Feel free to comment and bash :) -Matej
Matej Knopp wrote: > I will, but I can't do that in dayjob :) I guess it will break couple > (lot of?) tests and other things that will need to be fixed. > > -Matej > > Johan Compagner wrote: >> make the change! >> >> On 8/10/06, *Matej Knopp* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> >> wrote: >> >> right. this would be then moved to renderHead. >> >> in render head user can decide what to render and what to not render. We >> don't really need to divide that to renderHeadContribution and >> renderHeadInitContribution. it just doesn't feel right. >> >> -Matej >> >> Johan Compagner wrote: >> > the answer to that question is what does the >> onRenderHeadContribution() >> > exactly do >> > >> > I only see one implementation: >> > >> > if (this.attachedBodyOnLoadModifier == false) >> > { >> > this.attachedBodyOnLoadModifier = true; >> > >> > >> ((WebPage)getComponent().getPage()).getBodyContainer().addOnLoadModifier( >> > getJsTimeoutCall(updateInterval), >> getComponent()); >> > } >> > >> > in AbstractAjaxTimerBehavior >> > >> > johan >> > >> > >> > On 8/10/06, *Matej Knopp* <[EMAIL PROTECTED] <mailto:[EMAIL >> PROTECTED]> >> <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> wrote: >> > >> > Johan Compagner wrote: >> > > no not really >> > > >> > > look at AbstractAjaxBehavior >> > > >> > > that has 3 methods: >> > > >> > > public final void renderHead(final Response response) (of the >> > interface) >> > > that calls 2 methods: >> > > >> > > protected void onRenderHeadInitContribution(final Response >> response) >> > > protected void onRenderHeadContribution(final Response >> response) >> > >> > Well, maybe I'm wrong, but if the header contribution works as we >> > agreed >> > it should, do we need those two? What's the additional value? >> > >> > > >> > > >> > > what the difference is between those 2, i dont know >> > > first is only called once >> > > but the second all the time. >> > > So guess for us the first is what we try to implement. >> > > But i don't know where the second is then exactly used for. >> > > (if that one can add things to the header no matter how many >> > times the >> > > behaviour is there on the page) >> > > >> > > johan >> > > >> > > >> > > >> > > >> > > So far I agree, except that >> > > protected void onRenderHeadInitContribution(final >> IHeaderResponse >> > > response) >> > > should read renderHead(final IHeaderResponse response), >> > shouldn't it? >> > > (method from IHeaderContributor) >> > > >> > > So... erm... who's going to... erm... implement this? >> > > >> > > -Matej >> > > >> > > > Much nicer if you ask me and for developers that are >> > coding these >> > > header >> > > > contributors >> > > > it is much more self explaining. You dont need to know >> > about a vague >> > > > class with some static methods >> > > > that you should call instead of directly the >> response.write() >> > > > >> > > > But maybe i am missing something right now that i >> am not >> > seeing >> > > at this >> > > > late hour ... >> > > > >> > > > Johan >> > > > >> > > > >> > > > On 8/9/06, *Matej Knopp* <[EMAIL PROTECTED] >> <mailto:[EMAIL PROTECTED]> >> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> >> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> >> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> >> > > <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> >> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> >> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> <mailto: >> [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>>> wrote: >> > > > >> > > > On ##wicket we came to a conclusion that we need to >> > unify and >> > > simplify >> > > > the way duplicated header contributions are >> filtered. >> > We want >> > > to make it >> > > > as simple as possible, but yet powerful enough >> to be >> > able to >> > > handle >> > > > non-trivial usecases. >> > > > >> > > > The current draft looks like this: >> > > > >> > > > public class HeaderContribution >> > > > { >> > > > static public void >> > > > renderJavascriptReference(PackageResourceReference >> > > > reference, Response response); >> > > > >> > > > static public void >> > > renderCSSReference(PackageResourceReference >> > > > reference, Response response); >> > > > >> > > > static public void renderString(String >> string, >> > Response >> > > > response); >> > > > >> > > > static public void markRendered(Object >> object); >> > > > >> > > > static public boolean >> wasRendered(Object object); >> > > > >> > > > static public void detach(); >> > > > } >> > > > >> > > > The usage should be like this: >> > > > >> > > > class MyBehavior extends AbstractBehavior >> > > > >> > > > private static PackageResourceReference >> > myJavascript = ...; >> > > > >> > > > private static PackageResourceReference >> myCSS = ...; >> > > > >> > > > protected void renderHead(Response resp) { >> > > > >> HeaderContribution.renderJavascriptReference >> > (myJavascript, >> > > > response); >> > > > HeaderContribution.rednerCSSReference >> (myCss, >> > response); >> > > > } >> > > > >> > > > ... >> > > > } >> > > > >> > > > Where HeaderContribution would take care of >> filtering >> > duplicate >> > > > contributions (using a Threadlocal containing a >> set of >> > already >> > > > contributed objects). >> > > > >> > > > Thoughs? >> > > > >> > > > -Matej >> > > > >> > > > >> > > >> > >> ------------------------------------------------------------------------- >> >> > > > Using Tomcat but need to do more? Need to >> support web >> > services, >> > > > security? >> > > > Get stuff done quickly with pre-integrated >> technology >> > to make >> > > your >> > > > job easier >> > > > Download IBM WebSphere Application Server v.1.0.1 >> > based on Apache >> > > > Geronimo >> > > > >> > > >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>> >> > > >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > < >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>> >> > > > < >> > > >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>> >> > > >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>>> >> > > > _______________________________________________ >> > > > Wicket-develop mailing list >> > > > Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>> >> > > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>>> >> > > > <mailto:Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>> >> > > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>>>> >> > > > >> > https://lists.sourceforge.net/lists/listinfo/wicket-develop >> <https://lists.sourceforge.net/lists/listinfo/wicket-develop> >> > > > >> > > > >> > > > >> > > > >> > > >> > >> ------------------------------------------------------------------------ >> > > > >> > > > >> > > >> > >> ------------------------------------------------------------------------- >> > >> > > >> > > > Using Tomcat but need to do more? Need to support web >> > services, >> > > security? >> > > > Get stuff done quickly with pre-integrated >> technology to make >> > > your job easier >> > > > Download IBM WebSphere Application Server v.1.0.1 >> based on >> > Apache >> > > Geronimo >> > > > >> > > >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>> >> > > >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > < >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>> >> > > > >> > > > >> > > > >> > > >> > >> ------------------------------------------------------------------------ >> >> > > > >> > > > _______________________________________________ >> > > > Wicket-develop mailing list >> > > > Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto:Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>> >> > > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto:Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>>> >> > > > >> https://lists.sourceforge.net/lists/listinfo/wicket-develop >> > > >> > > >> > > >> > >> ------------------------------------------------------------------------- >> > >> > > >> > > Using Tomcat but need to do more? Need to support web >> services, >> > > security? >> > > Get stuff done quickly with pre-integrated technology >> to make >> > your >> > > job easier >> > > Download IBM WebSphere Application Server v.1.0.1 >> based on Apache >> > > Geronimo >> > > >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>> >> > > >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>> >> > > _______________________________________________ >> > > Wicket-develop mailing list >> > > Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>> >> > > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>>> >> > > >> https://lists.sourceforge.net/lists/listinfo/wicket-develop >> > > < >> https://lists.sourceforge.net/lists/listinfo/wicket-develop> >> > > >> > > >> > > >> > > >> > >> ------------------------------------------------------------------------ >> >> > > >> > > >> > >> ------------------------------------------------------------------------- >> > >> > > Using Tomcat but need to do more? Need to support web >> services, >> > security? >> > > Get stuff done quickly with pre-integrated technology to make >> > your job easier >> > > Download IBM WebSphere Application Server v.1.0.1 based on >> Apache >> > Geronimo >> > > >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > < >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>> >> > > >> > > >> > > >> > >> ------------------------------------------------------------------------ >> >> > > >> > > _______________________________________________ >> > > Wicket-develop mailing list >> > > Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto:Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>> >> > > >> https://lists.sourceforge.net/lists/listinfo/wicket-develop >> <https://lists.sourceforge.net/lists/listinfo/wicket-develop> >> > >> > >> > >> ------------------------------------------------------------------------- >> > >> > Using Tomcat but need to do more? Need to support web services, >> > security? >> > Get stuff done quickly with pre-integrated technology to make >> your >> > job easier >> > Download IBM WebSphere Application Server v.1.0.1 based on Apache >> > Geronimo >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>> >> > _______________________________________________ >> > Wicket-develop mailing list >> > Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > <mailto: Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net>> >> > https://lists.sourceforge.net/lists/listinfo/wicket-develop >> <https://lists.sourceforge.net/lists/listinfo/wicket-develop> >> > <https://lists.sourceforge.net/lists/listinfo/wicket-develop> >> > >> > >> > >> > >> ------------------------------------------------------------------------ >> >> > >> > >> ------------------------------------------------------------------------- >> > Using Tomcat but need to do more? Need to support web services, >> security? >> > Get stuff done quickly with pre-integrated technology to make >> your job easier >> > Download IBM WebSphere Application Server v.1.0.1 based on Apache >> Geronimo >> > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> > >> > >> > >> ------------------------------------------------------------------------ >> > >> > _______________________________________________ >> > Wicket-develop mailing list >> > Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> > https://lists.sourceforge.net/lists/listinfo/wicket-develop >> >> >> ------------------------------------------------------------------------- >> >> Using Tomcat but need to do more? Need to support web services, >> security? >> Get stuff done quickly with pre-integrated technology to make your >> job easier >> Download IBM WebSphere Application Server v.1.0.1 based on Apache >> Geronimo >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> >> _______________________________________________ >> Wicket-develop mailing list >> Wicket-develop@lists.sourceforge.net >> <mailto:Wicket-develop@lists.sourceforge.net> >> https://lists.sourceforge.net/lists/listinfo/wicket-develop >> <https://lists.sourceforge.net/lists/listinfo/wicket-develop> >> >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> Using Tomcat but need to do more? Need to support web services, security? >> Get stuff done quickly with pre-integrated technology to make your job easier >> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Wicket-develop mailing list >> Wicket-develop@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
