SubmitLink can be both.. It can be build on a button (generate onclick)
But you don't have to introduce anything special because this line:
button = (Button)getPage().visitChildren(SubmitLink.class, new IVisitor()
can just become
button = (Button)getPage().visitChildren(Button.class, new IVisitor()
Because everything is a button...
johan
On 8/11/06, Frank Bille <[EMAIL PROTECTED]> wrote:
Good point. But then Button really needs to be able to submit a form which it's not part of. Else we will have to introduce AjaxSubmitLink in Form.findSubmittingButton.
FrankOn 8/11/06, Johan Compagner <[EMAIL PROTECTED]> wrote:Why would AjaxSubmitLink extends SubmitLink?
I get the name part that it seems that way
But purely functional so code reuse it is as far as i see nothing
Because what SubmitLink does on onComponentTag:
tag.put ("onclick", getTriggerJavaScript());
is really not needed or wanted for the AjaxSubmitLink..
Because ajax replaces that again with # and then again with the behaviour that does the final part there.
That looks to me like a waste. So as far as i can see. AjaxSubmitLink can just extend also button.
johanOn 8/11/06, Frank Bille < [EMAIL PROTECTED]> wrote:Hey
I have changed AjaxSubmitLink and AjaxSubmitButton to extend SubmitLink and Button (not committed yet). This gives us the plessure of having setDefaultFormProcessing on the AjaxSubmit*.
I have to "issues" that I would like your oppinions on:
- AjaxSubmitLink, SubmitLink AND AjaxSubmitButton can all be used outside of the form. They then use _javascript_ of course. Button is the only one which isn't allowed to do that. How about I change it so they all behave the same? Buttons should be allowed to submit a form even though it's not part of it.
- I see no API break, but do you see anything that will prevent it from being backported? (I guess that will be easier to answer when I commit something. I'll do that when I've dealt with 1.)
Frank
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
