Fixed in 2.0. Going to backport it now. Juergen
On 8/11/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > Unfortunately that can not be done with filters. The MarkupParser > dissects(?) the markup into wicket relevant tags (<wicket:xxx..> and > wicket:id). Everything else, including comments, is raw markup (text) > and remains untouched. > > Juergen > > On 8/11/06, Maurice Marrink <[EMAIL PROTECTED]> wrote: > > Actually there has been a request about markup parsing to leave comments > > like > > <!--[if IE]> blabla <![endif]--> in the final markup when stripping > > comments. > > If this could be done using those filters i am all for back porting it. > > > > Maurice > > > > On 8/11/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > > It doesn't fix a bug, and it is not needed for 1.2. There is no need > > > to put it into 1.2.2 > > > > > > Juergen > > > > > > On 8/11/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > > is it really needed for 1.2.2? Martijn is not really pro api changes ;) > > > > So if it is really a bug you have my vote > > > > else wait for 1.3? > > > > > > > > johan > > > > > > > > > > > > > > > > On 8/10/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > > > > > > > > I kept on working on MarkupParser and MarkupParserFactory. Extending > > > > MarkupParser, especially adding additional IMarkupFilter, was bit of a > > > > pain. MarkupParserFactory offered additional constructor with the > > > > intend to simplify it but actually using these constructors was > > > > dangerous as the IMarkupFilters provided with these construtors must > > > > have been stateless. I changed MarkupParser in a way that a single > > > > instance can now only be used once. Which is how it is used anyway, > > > > except for testing. MarkupParserFactory now returns a MarkupParser and > > > > you can simply call markuParser.registerMarkupFilter(). > > > > This change > > > > shouldn't affect many users, but the API has slighty changed. The > > > > change is backportable. Any thoughts? > > > > > > > > Wicket-bench will need a facade to support multiple wicket versions. > > > > > > > > Juergen > > > > > > > > ------------------------------------------------------------------------- > > > > Using Tomcat but need to do more? Need to support web services, > > > > security? > > > > Get stuff done quickly with pre-integrated technology to make your job > > > > easier > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > > > > Geronimo > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > _______________________________________________ > > > > Wicket-develop mailing list > > > > Wicket-develop@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > Using Tomcat but need to do more? Need to support web services, > > > > security? > > > > Get stuff done quickly with pre-integrated technology to make your job > > > > easier > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > > > > Geronimo > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > > _______________________________________________ > > > > Wicket-develop mailing list > > > > Wicket-develop@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > Using Tomcat but need to do more? Need to support web services, security? > > > Get stuff done quickly with pre-integrated technology to make your job > > > easier > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > _______________________________________________ > > > Wicket-develop mailing list > > > Wicket-develop@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
