That's all true. Don't get me wrong. I don't mind having several means to test wicket components. For me it is much more important that we do create unit tests and that we run the tests before committing.
On 8/22/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > i suppose an advantage is that you have a bit more context about what the > test is testing for. if you look at AjaxSubmitButtonTest:78-81 you can > clearly see what the expected bits are. > true, but side effect are less likely to be detected. Javadocs may also explain what the test is about. > i supposed another advantage would be that you dont have to maintain 3 files > per test for smaller tests. you can override the markup loading and feed it > from a string - then use the tag tester to test the output. you can do the > same for template matching i suppose, but then you have to maintain two > markup strings in code. I can only talk about the experience at the beginning of wicket where we started like this. I don't mind having different means and IMO there is no need to come with a list of pros and cons. Everyone should use what he likes best. Creating the unit tests is the important thing. Juergen > > -Igor > > > > On 8/22/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > On 8/21/06, Frank Bille <[EMAIL PROTECTED]> wrote: > > > And don't get me wrong. I'm not surgesting anything like rewriting all > test > > > to use some sort of TagTester. I'm just saying that perhaps it can be > used > > > as a supplement or in some cases a replacement for the diff-test. > > > > > > But I think it can be a good way to test more different cases with less > > > effort. What I test in the AjaxSubmitLink test is for example something > that > > > Matej and I talked about on IRC a few days ago. And that is that the > onclick > > > attribute ends with "return false;" which is important if you don't want > "#" > > > to be added to the address field in the browser. It was quite easy to > write > > > a test for that using the TagTester, while if I had to test that > otherwise > > > it was a more demanding task. > > > > Calling WicketTestCase.executeXXX() and copying the output markup into > > a file doesn't seem to be very demanding. > > > > > > > > - Frank > > > > > > P.S. Matej: I know we didn't exactly talked about AjaxSubmitLink, but I > > > remembered our talk when writing the test. :) > > > > > > > > > > > > > > > On 8/21/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote: > > > > > > > > dont get me wrong, im not saying the tagtester is better, in fact i > havent > > > looked at it yet, im just telling you what i dont like about our current > > > system. ive ran into it a lot - i change how a url for an ajax call is > > > generated - and all of a sudden a bunch of things break. im always > worried > > > about running with expected.results=true before i look over everything > that > > > broke to make sure it really didnt - and that takes a long time. > > > > > > > > i guess the thing is that unexpected things break. for example if i > change > > > how a behavior works then all the tests for components with that > behavior > > > also break - which is a bit wrong because only the tests that test the > > > behavior directly should break. but maybe that is the best we can do for > > > wicket. > > > > > > > > > > > > -Igor > > > > > > > > > > > > > > > > On 8/21/06, Juergen Donnerstag < [EMAIL PROTECTED]> wrote: > > > > > But it is very easy to fix. Just add > > > > > -Dwicket.replace.expected.results=true while > executing > > > the tests. How > > > > > often to change all the headers? I looked at TagTester and it is > very > > > > > similar to what we used to have. Because it tests only very little, > it > > > > > will hardly ever detect any side effects. And it is much more > > > > > difficult to maintain in case of changes; think of regular changes > to > > > > > the javascript. > > > > > > > > > > But I'm not the master of the junit tests, it should be everyones > > > > > concern. I don't care which methods we are using as long as we are > > > > > creating unit tests at all and as long everyone runs the tests prior > > > > > to committing. > > > > > > > > > > Juergen > > > > > > > > > > > > > > > On 8/21/06, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > > > i think its fragile because for example, if we do something to > head of > > > all > > > > > > pages - cookie/window.name change, then all the tests sunddenly > break. > > > thats > > > > > > the part that sucks. > > > > > > > > > > > > -Igor > > > > > > > > > > > > > > > > > > > > > > > > On 8/21/06, Juergen Donnerstag < [EMAIL PROTECTED] > > wrote: > > > > > > > We tried it some time back, actually we started with something > > > > > > > similar, but IMO it was horrible to maintain. But more > importantly > > > > > > > because it focusses on a small part of the markup output only, > it > > > > > > > failed to detect at all the tiny side effects some changes > created. > > > > > > > That is probably why it is perceived fragile. > > > > > > > > > > > > > > Juergen > > > > > > > > > > > > > > On 8/21/06, Frank Bille < [EMAIL PROTECTED]> wrote: > > > > > > > > Hey > > > > > > > > > > > > > > > > I have played a little around with how to test rendered markup > > > without > > > > > > > > having to do the somewhat fragile cached-markup-diff-thingy. I > > > have > > > > > > > > committed a draft version of a TagTester which, based on the > > > rendered > > > > > > > > markup, allows testing of specific tags without having to rely > on > > > the > > > > > > > > attributes being in the correct order etc. It is still just a > > > draft and > > > > > > is > > > > > > > > expected to be expanded to include various ways of testing the > > > markup. > > > > > > > > > > > > > > > > The tagtester is in wicket.util.tester.TagTester and is used > in > > > (test) > > > > > > > > > > > > > > > > > > wicket.ajax.markup.html.form.AjaxSubmit(Button|Link)Test > > > > > > > > > > > > > > > > How does this sound as a testing concept? > > > > > > > > > > > > > > > > > > > > > > > > - Frank > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > > > Using Tomcat but need to do more? Need to support web > services, > > > > > > security? > > > > > > > > Get stuff done quickly with pre-integrated technology to make > your > > > job > > > > > > > > easier > > > > > > > > Download IBM WebSphere Application Server v.1.0.1 based on > Apache > > > > > > Geronimo > > > > > > > > > > > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > Wicket-develop mailing list > > > > > > > > Wicket-develop@lists.sourceforge.net > > > > > > > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > > Using Tomcat but need to do more? Need to support web services, > > > security? > > > > > > > Get stuff done quickly with pre-integrated technology to make > your > > > job > > > > > > easier > > > > > > > Download IBM WebSphere Application Server v.1.0.1 based on > Apache > > > Geronimo > > > > > > > > > > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > _______________________________________________ > > > > > > > Wicket-develop mailing list > > > > > > > Wicket-develop@lists.sourceforge.net > > > > > > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > Using Tomcat but need to do more? Need to support web services, > > > security? > > > > > > Get stuff done quickly with pre-integrated technology to make your > job > > > > > > easier > > > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > > > Geronimo > > > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > > > > > > _______________________________________________ > > > > > > Wicket-develop mailing list > > > > > > Wicket-develop@lists.sourceforge.net > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > Using Tomcat but need to do more? Need to support web services, > > > security? > > > > > Get stuff done quickly with pre-integrated technology to make your > job > > > easier > > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > > > Geronimo > > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > _______________________________________________ > > > > > Wicket-develop mailing list > > > > > Wicket-develop@lists.sourceforge.net > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > Using Tomcat but need to do more? Need to support web services, > security? > > > > Get stuff done quickly with pre-integrated technology to make your job > > > easier > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > > _______________________________________________ > > > > Wicket-develop mailing list > > > > Wicket-develop@lists.sourceforge.net > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > Using Tomcat but need to do more? Need to support web services, > security? > > > Get stuff done quickly with pre-integrated technology to make your job > > > easier > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > _______________________________________________ > > > Wicket-develop mailing list > > > Wicket-develop@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
