I'm not sure... If wicket could close the input stream it would be fine. If not maybe we should consider renaming the method to new/createInputStream() ? So that it's obvious that the user is responsible for closing the stream.
-Matej Johan Compagner wrote: > what should be the best solution for this then? > > Just document it that a new stream is created everytime when you call > that method > and you need to close it? Or that the closing part is done by wicket itself? > > johan > > > On 8/21/06, *Matej Knopp* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > wrote: > > Yeah. +1 > > I've been using file upload and I'm not sure if I've closed it all the > time. Hmm.. some nasty leaks could have been there... I should go and > check it. > > -Matej > > SourceForge.net wrote: > > Bugs item #1543832, was opened at 2006-08-21 11:53 > > Message generated for change (Tracker Item Submitted) made by > Item Submitter > > You can respond by visiting: > > > > https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1543832&group_id=119783 > > <https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1543832&group_id=119783> > > > > Please note that this message will contain a full copy of the > comment thread, > > including the initial issue submission, for this request, > > not just the latest update. > > Category: None > > Group: 1.2 > > Status: Open > > Resolution: None > > Priority: 5 > > Submitted By: Johan Compagner (joco01) > > Assigned to: Nobody/Anonymous (nobody) > > Summary: FileUpload must be documented better > > > > Initial Comment: > > because we do this: > > > > public InputStream getInputStream() throws IOException > > { > > if (!dfos.isInMemory()) > > { > > return new FileInputStream(dfos.getFile()); > > } > > > > if (cachedContent == null) > > { > > cachedContent = dfos.getData(); > > } > > return new ByteArrayInputStream(cachedContent); > > } > > > > that means we don't have a reference to the inputstream > > WE make. So the outside world should close the > > inputstream. This should really be documented. Or we > > should keep a reference somewhere and have a close that > > is called. so that we close it ourselfs. > > > > > > > > > ---------------------------------------------------------------------- > > > > You can respond by visiting: > > > > https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1543832&group_id=119783 > > <https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1543832&group_id=119783> > > > > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, > security? > > Get stuff done quickly with pre-integrated technology to make > your job easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > <mailto:Wicket-develop@lists.sourceforge.net> > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, > security? > Get stuff done quickly with pre-integrated technology to make your > job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642> > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > <mailto:Wicket-develop@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > ------------------------------------------------------------------------ > > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
