On 9/9/06, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote: > * Juergen Donnerstag: > > I understand this to be refactoring and that all existing unit tests > > for wicket are still working? > > That's right the wicket unit tests should be updated to replace: > > new WicketTester() > > with: > > new WebApplicationTester(new DummyApplication()) > > > Can this approach be applied to Application in general? See > > http://sourceforge.net/tracker/index.php?func=detail&aid=1458736&group_id=119783&atid=684975 > > No, this is not the same issue. I don't really agree with > [1458736 ] Do something about the proliferation of Application types > IMHO it's a non-issue. > > But what about my proposition? I have the feeling that Wicket > testing framework is not yet bulletproof and should be improved.
I definitely agree and I'm more than happy that you are improving it. > Another example: I found a bug yesterday that basically prevents > from using String arrays (same parameter repeated multiple times > in the request parameters) in tests. And I noticed indeed that > MockHttpServletRequest.setRequestToRedirectString() > needs some severe rewriting... > > However string arrays do not work either in Wicket core, as > explained here: > > [ 1493672 ] Handle String array in PageParameters > http://sourceforge.net/tracker/index.php?func=detail&aid=1493672&group_id=119783&atid=684977 > > BTW this bug report has been submitted in May, without any comment > in nearly four months. No comment probably means that no one disagrees but you seem to be the only one using it. Having said that, no matter how many users are using it should be fixed and it will be fixed (hopefully soon). > > Am I the only one to use WicketTester intensively? And the only > one using String arrays in Wicket? I can't believe it :-) Definitely not. Most of our junit test cases are based on WicketTester but as you discovered, not every tiny bit of functionality is covered. We are following an interative approach and are adding test case with almost every bug fixed, to avoid regression. Juergen > -- > Jean-Baptiste Quenot > aka John Banana Qwerty > http://caraldi.com/jbq/ > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
