The markup handler are called just once when the markup is loaded. If you have 2 or more components of the same type, the markup will still only be loaded once and hence the markup handler only be called once. Markup Handlers are the wrong place to do it. In 1.2 (and 2.0) we have resolvers to do similar work, though they work on wicket:id and wicket:xxx (which means a corresponding component must exist). If neither of both is present, than the resolver won't be able to handle it. WicketMessageTaghandler didn't need (I didn't look at the new code yet) to know the component and the stack yet, as the properties were assumed to be either in the corresponding properties file or the apps properties file. Which is properly the limitation Eelco was talking about.
Juergen On 9/18/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > it would be cool if the tag handler can somehow add an attribute modifier to > the created component, that would solve all these problems. but i guess its > not exactly how it works right now :) > > -Igor > > > > On 9/17/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > WicketMessageTagHandler is pretty limited currently, with only the the > > component initiating the markup loading in the search stack. I fixed > > this for 2.0 by setting the component path and later using that > > component path to resolve the component again. I think this shouldn't > > be a problem as passing that container and filtering the content > > would be done very shortly after each other, without the possibility > > of the original component being replaced (which would result in the > > path resolving to the wrong component). But if I overlooked something, > > please tell. > > > > I'm not sure if we can do this for 1.2 though, as markup loading can > > be triggered from many locations, including during construction time, > > meaning that we wouldn't have enough information to resolve the > > component. If we don't find a solution, we should consider removing > > WicketMessageTagHandler from 1.2 altogether imo, as it is so limited. > > > > Another issue is that reloading of messagebundles have no effect. I > > guess that would be very hard to workaround for? > > > > Another thing I noticed is that when I load another version of the > > markup, e.g. when switching the locale, the filter applies the changes > > but somehow the older markup is used as long as I render the same > > component instance. Any idea how that might happen? > > > > Eelco > > > > > > On 9/17/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > Ah, forget it. I just found out about the experimental tag handler > > > Juergen put committed. I'll look at that now. > > > > > > Eelco > > > > > > > > > On 9/17/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > > We had a discussion and a vote on localized attributes some time ago: > > > > > http://www.nabble.com/VOTE%3A-how-should-localized-attributes-work--tf2047179.html#a5637727 > > > > > > > > Seems that most people voted for > > > > > > > > 2) <input type="submit" value="Default Value" > wicket:message="value:my_key"/> > > > > > > > > Though it was also mentioned we could support both cases but advertise > just one. > > > > > > > > There is no feature request for this yet and it doesn't seem to be > > > > implemented either, is that correct? > > > > > > > > I'm writing a section about localization now, so if we're gonna have > > > > this feature, and it's not too difficult to implement, I could write > > > > about it, provided it would be implemented soon (like this week). > > > > > > > > Thoughts? > > > > > > > > Eelco > > > > > > > > > > > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
