I have no preference other than the colon makes my code look a bit neater!

Chris

Martijn Dashorst wrote:

I am in the 'want to use the component id as (limited) ognl expression' camp. I think that the component seperator should be either colon (":") or dollar sign ("$"). Visually I have a preference for the colon, but mentally I prefer the $. The $ is already in use for generating the class files for inner classes, so it seems like a natural fit for seperating components as one may have already seen it before. As a /clear/ seperator the colon stands out more.

In the end I'd choose the colon.

Martijn


Eelco Hillenius wrote:

That would be pretty difficult I think. Say, you used 'foo.bar' as your component name, and we translate it to 'foo:bar' internally. We we still have to figure out that in the markup it is denoted as 'foo.bar' (so we have to keep the original), but for generating links etc, we would use the translated one. Seems pretty error prone, though the basic idea is good.

I think using a seperator like ':' is in nobody's way: I think it is very unlikely that anyone will use it as part of their component name, and just in case, we could build in a check for that too. And using CompoundPropertyModels with the dotted notation would be great, and is an issue that has come up several times now on this list (clear indication it should be fixed).

Eelco

Gili wrote:


I would suggest the following "radical idea": component path is an internal concept. End-users never get to manipulate Wicket using a specific component path. We only seem to use it to output debug messages and for internal house keeping (to keep track of the structure). As such, we don't care whether dots or semicolon or whatever are used. Furthermore, I would argue, it shouldn't matter.

Either invent a String encoding mechanism where "." denotes a component separator and ".." denotes a OGNL seperator that has been encoded or represent a path using a simple List structure instead of String. At the end of the day, ensure that the new implementation does not depend on *any* character not getting used in the future. It should be smart enough to encode away any conflicts or use a non-String internal representation.

    Is that feasiable?

Gili

Eelco Hillenius wrote:

Currently, you can't do:

add (new RequiredTextField("company.name"));

(which is: use company.name as an id) as Wicket thinks that company and name are seperate components because of the '.', which is Wicket's path seperateor. This is unfortunate, as it is a valid Ognl expression (which means to get the name property of the company property of the target object).

Eelco

Gili wrote:


I somewhat object... I like the current behavior. Maybe I don't understand what you are refering to by a "component path". Where is this used in Wicket? Can you give me an example String where the dot is ambigious whether it is a OGNL thing or component path thing? Is it really possible to have a subcomponent having the exact same name as a OGNL "member of a class" and have it refer to two different objects?

Thanks,
Gili








-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user





-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user





-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user





-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to