Won't it be comparing with the models from the last request? You know, those models that were detached and may be discarded, never to be attached again save that comparison?
Another problem is that I don't want the DataView using value equality when row equality is available, which it always will be in this case. I think if you want to make it more general, use the model's equals so that it can use value, row, or object identity. I don't think that requiring a proper implementation of equals on the model is any different from requiring it on the object and it gives you more options. On 8/15/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > Unless you are using a unique key I don't see how your model is going to > know other then delegate to the object anyways. > And hopefully your persistence layer is smart enough to pull N+1 queries out > of cache since you will be doing that anyways when you render. > -Igor > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf Of > > Phil Kulak > > Sent: Sunday, August 14, 2005 11:52 PM > > To: [email protected] > > Subject: Re: [Wicket-user] [Wicket] DataView and optimized > > item removal > > > > > So as far as the patch goes, I > > > like the idea but maybe we should just do > > > model.getModelObject().equals(model2.getModelObject()) as > > opposed to > > > model.equals(model2). > > > > You can get yourself into some nasty N + 1 select problems > > like that if you're not careful. I think it's a bad idea to > > do an attach just to do a comparison that the model knows how > > to do anyway. > > > > > > ------------------------------------------------------- > > SF.Net email is Sponsored by the Better Software Conference & > > EXPO September 19-22, 2005 * San Francisco, CA * Development > > Lifecycle Practices Agile & Plan-Driven Development * > > Managing Projects & Teams * Testing & QA Security * Process > > Improvement & Measurement * http://www.sqe.com/bsce5sf > > _______________________________________________ > > Wicket-user mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > _______________________________________________ > Wicket-user mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-user > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
