There has been some changes to autolinks (<wicket:link>) as well, as
they didn't work for none-html. But I think / hope I didn't change
anything for html autolinks.
<wicket:link> automatically creates the required components for you.
In case of html it is a BookmarkablePageLink, which is obvious from
your output as well. BookmarkablePageLink are based on Links which
implement the autoEnable/disable behaviour which by default is on and
which will disable (write span tag) in case the url would point to the
current page (in your case the home page). From that point of view,
the b4 output is what I would expect.
But I understand that this behaviour is not what you want as you have
css attached to the anchor tag which obviously does not apply for the
span tag. Autolinks (<wicket:link>) are somewhat limited because you
can not modifiy there behaviour; you can disable the autoEnable
feature e.g. for all links created. Unfortunately I don't see a quick
fix. I see on the following two solution to your problem: a) modify
you css to handle the span as well or b) remove wicket:link and
manually add(new Bookmarkable(...).setAutoEnable(false)) the links
Juergen
On 9/2/05, Jeremy Hulick <[EMAIL PROTECTED]> wrote:
> Juergen, I did not add the <wicket:link> tag. We have had
> settings.setStripWicketTag(true) set in our application from the start
> (since late May, v1.0.1), and this is the first time we are seeing this
> behavior. One thing that has changed since the start, but occured back in
> late June, is that we integrated with Spring. The
> settings.setStripWicketTag(true) was originally being called in our
> Application constructor, now it is being called in the afterPropertiesSet()
> method. So, the behavior that I see is that with Wicket v1.1 b3 and Spring,
> the settings.setStripWicketTag (true) is not working, but with Wicket v1.1
> b4 it is - but this seems like a different issue. Any thoughts on the nested
> <span> tag?
>
> -- Jeremy
>
>
> On 9/2/05, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
> >
> > <wicket:link> must have been added by you. We do not add it
> > automatically. But, we changed the autolink (<wicket:link>) code and
> > it may be related to that change, though i'm not yet convinced as none
> > of the other user had to change there markup (at least that I know
> > of).
> >
> > Did you set seetings.setStripWicketTag(true) lately (or between b3 and
> > b4, becuase that wold explain why wicket:link is included in the
> > output in one example but not in the other.
> >
> > Juergen
> >
> > On 9/2/05, Jeremy Hulick <[EMAIL PROTECTED]> wrote:
> > > Eelco / Juergen,
> > >
> > > Bear with me, I am a novice at the client side programming. As it
> turns
> > > out, my menu buttons were hidden below the menu bar but were still
> > > functional. Anyway, it seems that the source of the problem lies in the
> > > difference of how v1.1 b3 and v1.1 b4 render the Links. For starters,
> here
> > > is the HTML for the MyPanel class:
> > >
> > > <wicket:panel>
> > > <wicket:link><a
> > > href="/com/medigy/app/pbs/page/Home.html">Home</a>
> > > <a
> > > href="/com/medigy/app/pbs/page/Search.html">Search</a>
> > >
> > > <a
> > >
> href="/com/medigy/app/pbs/page/Worklists.html">Worklists</a>
> > > <a
> > > href="/com/medigy/app/pbs/page/Report.html">Reports</a>
> > > <a
> > >
> href="/com/medigy/app/pbs/page/worklist/ScheduleDesk.html">Schedule
> > > Desk</a>
> > > <a
> > > href="/com/medigy/app/pbs/page/test/Test0.html">Layout
> > > Samples</a>
> > > </wicket:link>
> > > </wicket:panel>
> > >
> > >
> > >
> > > Now, when the application renders my menu, at the Home page, here is
> the
> > > source that is generated for both v1.1 b3 and v1.1 b4. I've highlighted
> the
> > > differences:
> > >
> > >
> > > v1.1 b4
> > >
> > > <table cellpadding="0" cellspacing="0" width="100%" class="inner">
> > > <tr valign="top">
> > > <td width="100%">
> > > <div class="masthead">Medigy Platform Demo</div>
> > > <div class="main-menu">
> > > <span>
> > > <span><i>Home</i></span>
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.Search"
> > > Search</a>
> > > <a
> > > href="/medigy-pbs/app?bookmarkablePage=
> com.medigy.app.pbs.page.Worklists">Worklists</a>
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.Report">Reports</a>
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.worklist.ScheduleDesk">Schedule
> > > Desk</a>
> > > <a
> > > href="/medigy-pbs/app?bookmarkablePage=
> com.medigy.app.pbs.page.test.Test0">Layout
> > > Samples</a>
> > > </span>
> > > </div>
> > > </td>
> > >
> > > v1.1 b3
> > >
> > > <table cellpadding="0" cellspacing="0" width="100%" class="inner">
> > > <tr valign="top">
> > > <td width="100%">
> > > <div class="masthead">Medigy Platform Demo</div>
> > > <div class="main-menu">
> > > <span>
> > > <wicket:link><a
> > > href="/medigy-pbs/app?bookmarkablePage=
> com.medigy.app.pbs.page.Home
> > > ">Home</a>
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.Search">Search</a>
> > >
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.Worklists">Worklists</a>
> > > <a
> > > href="/medigy-pbs/app?bookmarkablePage=
> com.medigy.app.pbs.page.Report">Reports</a>
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.worklist.ScheduleDesk">Schedule
> > > Desk</a>
> > > <a
> > >
> href="/medigy-pbs/app?bookmarkablePage=com.medigy.app.pbs.page.test.Test0">Layout
> > > Samples</a>
> > > </wicket:link>
> > > </span>
> > > </div>
> > >
> > > </td>
> > >
> > > It seems that the extra <span> is affecting the formatting of the
> buttons.
> > > Perhaps there is a simple fix I am overlooking?
> > >
> > > Thanks,
> > >
> > > Jeremy
> > >
> > >
> > >
> > >
> > > On 9/1/05, Eelco Hillenius <[EMAIL PROTECTED] > wrote:
> > > > I just tested it, and everything works fine here. Here's the patch of
> > > > what I tried on wicket-examples.
> > > >
> > > > I think your problems is somewhere else. Could you give us some more
> > > > information?
> > > >
> > > > Eelco
> > > >
> > > >
> > > >
> > > > Index:
> > > src/java/wicket/examples/helloworld/HelloWorld.html
> > > >
> > >
> ===================================================================
> > > > RCS file:
> > >
> /cvsroot/wicket/wicket-examples/src/java/wicket/examples/helloworld/HelloWorld.html,v
> > > > retrieving revision 1.11
> > > > diff -u -r1.11 HelloWorld.html
> > > > ---
> src/java/wicket/examples/helloworld/HelloWorld.html 3
> > > Apr 2005
> > > > 09:24:52 -0000 1.11
> > > > +++
> src/java/wicket/examples/helloworld/HelloWorld.html 1
> > > Sep 2005
> > > > 22:20:29 -0000
> > > > @@ -7,5 +7,8 @@
> > > > <body>
> > > > <span wicket:id="mainNavigation"/>
> > > > <span wicket:id="message" id="message">Message goes here</span>
> > > > +
> > > > + <span wicket:id="p"></span>
> > > > +
> > > > </body>
> > > > </html>
> > > > Index:
> > > src/java/wicket/examples/helloworld/HelloWorld.java
> > > >
> > >
> ===================================================================
> > > > RCS file:
> > >
> /cvsroot/wicket/wicket-examples/src/java/wicket/examples/helloworld/HelloWorld.java,v
> > > > retrieving revision 1.5
> > > > diff -u -r1.5 HelloWorld.java
> > > > ---
> src/java/wicket/examples/helloworld/HelloWorld.java 9
> > > Feb 2005
> > > > 09:42:25 -0000 1.5
> > > > +++
> src/java/wicket/examples/helloworld/HelloWorld.java 1
> > > Sep 2005
> > > > 22:20:29 -0000
> > > > @@ -20,6 +20,7 @@
> > > >
> > > > import wicket.examples.WicketExamplePage;
> > > > import wicket.markup.html.basic.Label ;
> > > > +import wicket.markup.html.link.Link;
> > > >
> > > > /**
> > > > * Everybody's favorite example!
> > > > @@ -33,6 +34,16 @@
> > > > */
> > > > public HelloWorld()
> > > > {
> > > > - add(new Label("message", "Hello World!"));
> > > > - }
> > > > + add(new Label("message", "Hello World!"));
> > > > + Link l = new Link("l")
> > > > + {
> > > > + public void onClick()
> > > > + {
> > > > +
> > >
> System.err.println("HHSDFJHDFKJHDFJKHSDJKHSFDKJDSHJKDFS");
> > > > + }
> > > > + };
> > > > + MyPanel p = new MyPanel("p");
> > > > + p.add(l);
> > > > + add(p);
> > > > + }
> > > > }
> > > > \ No newline at end of file
> > > > Index:
> src/java/wicket/examples/helloworld/MyPanel.html
> > > >
> > >
> ===================================================================
> > > > RCS file:
> > > src/java/wicket/examples/helloworld/MyPanel.html
> > > > diff -N
> src/java/wicket/examples/helloworld/MyPanel.html
> > > > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > > > +++ src/java/wicket/examples/helloworld/MyPanel.html
> 1
> > > Jan 1970 00:00:00 -0000
> > > > @@ -0,0 +1,3 @@
> > > > +<wicket:panel>
> > > > + <a wicket:id="l" href="#">hi</a>
> > > > +</wicket:panel>
> > > > Index:
> src/java/wicket/examples/helloworld/MyPanel.java
> > > >
> > >
> ===================================================================
> > > > RCS file:
> > > src/java/wicket/examples/helloworld/MyPanel.java
> > > > diff -N
> src/java/wicket/examples/helloworld/MyPanel.java
> > > > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > > > +++ src/java/wicket/examples/helloworld/MyPanel.java
> 1
> > > Jan 1970 00:00:00 -0000
> > > > @@ -0,0 +1,42 @@
> > > > +/*
> > > > + * $Id$
> > > > + * $Revision$
> > > > + * $Date$
> > > > + *
> > > > + *
> > >
> ==============================================================================
> > > > + * Licensed under the Apache License, Version 2.0 (the "License");
> you
> > > may not
> > > > + * use this file except in compliance with the License. You may
> > > > obtain a copy of
> > > > + * the License at
> > > > + *
> > > > + * http://www.apache.org/licenses/LICENSE-2.0
> > > > + *
> > > > + * Unless required by applicable law or agreed to in writing,
> software
> > > > + * distributed under the License is distributed on an "AS IS" BASIS,
> > > WITHOUT
> > > > + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> See
> > > the
> > > > + * License for the specific language governing permissions and
> > > > limitations under
> > > > + * the License.
> > > > + */
> > > > +package wicket.examples.helloworld ;
> > > > +
> > > > +import wicket.Component;
> > > > +import wicket.MarkupContainer;
> > > > +import wicket.markup.html.link.Link ;
> > > > +import wicket.markup.html.panel.Panel;
> > > > +
> > > > +
> > > > +public class MyPanel extends Panel
> > > > +{
> > > > + public MyPanel(String id)
> > > > + {
> > > > + super(id);
> > > > +
> > > > + }
> > > > + public MarkupContainer add(final Component component)
> > > > + {
> > > > + // we don't want any of our links to be auto enabled because
> > > > we use CSS ...
> > > > + if(component instanceof Link)
> > > > + ((Link) component).setAutoEnable(false);
> > > > +
> > > > + return super.add(component);
> > > > + }
> > > > +}
> > > >
> > > >
> > > >
> -------------------------------------------------------
> > > > SF.Net email is Sponsored by the Better Software Conference & EXPO
> > > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> > > Practices
> > > > Agile & Plan-Driven Development * Managing Projects & Teams * Testing
> & QA
> > > > Security * Process Improvement & Measurement *
> http://www.sqe.com/bsce5sf
> > > > _______________________________________________
> > > > Wicket-user mailing list
> > > > [email protected]
> > > >
> https://lists.sourceforge.net/lists/listinfo/wicket-user
> > > >
> > >
> > >
> >
> >
> > -------------------------------------------------------
> > SF.Net email is Sponsored by the Better Software Conference & EXPO
> > September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> Practices
> > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> > _______________________________________________
> > Wicket-user mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> >
>
>
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user
