" I've got a meta redirect tag. In older releases of Wicket"
(meta tags are in the head)
it has something to do with the TransparentWebMarkupContainer class
that one is calling renderComponent() immediantly on a component. (not render() who checks the visibliltiy)
johan
On 9/13/05, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
I've tested it last night and did not find any bug. It seems to work
with pages, borders, panels and all other basic components. It has
something to do with headers (again). Are you trying to disable a
component with header component? Is it a header in-side component
which you try to disable?
Juergen
On 9/13/05, Gili <[EMAIL PROTECTED]> wrote:
>
> Bug #1289391 has been filed for this issue.
>
> Gili
>
> Johan Compagner wrote:
> > ahh it seems that
> > public final boolean resolve(final MarkupContainer container,
> > final MarkupStream markupStream, final ComponentTag tag)
> > {
> > Component component = this.container.get(tag.getId());
> > if (component != null)
> > {
> > component.renderComponent(markupStream);
> > component.rendered();
> > return true;
> > }
> >
> > should call render() on that component
> > or do the same that the component does in render so checking for visiblility
> > But Juergen knows better then me whe it must call renderComponent directly
> > i think the markup stream will not resolve right when calling render() ??
> >
> >
> > On 9/12/05, *Gili* <[EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED] >> wrote:
> >
> >
> > It looks like the problem lies with
> > "TransparentWebMarkupContainer"
> > which I am not familiar with... Here is the full stack-trace:
> >
> > desktopbeautifier.web.contactus.Page$1.onComponentTag(Page.java :74)
> > at wicket.Component.renderComponent(Component.java:1837)
> > at
> > wicket.markup.html.WebMarkupContainer$TransparentWebMarkupContainer.resolve(WebMarkupContainer.java:286)
> > at wicket.MarkupContainer.renderNext
> > (MarkupContainer.java:1142)
> > at
> > wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:794)
> > at
> > wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:736)
> > at wicket.Component.renderComponent (Component.java:1860)
> > at
> > wicket.markup.html.WebMarkupContainer.onRender(WebMarkupContainer.java:73)
> > at wicket.Component.render(Component.java:1145)
> > at wicket.MarkupContainer.autoAdd( MarkupContainer.java:168)
> > at
> > wicket.markup.html.WebMarkupContainer.renderHead(WebMarkupContainer.java:97)
> > at wicket.markup.html.WebPage$1.component (WebPage.java:319)
> > at wicket.MarkupContainer.visitChildren
> > (MarkupContainer.java:620)
> > at
> > wicket.markup.html.WebPage.renderHeaderSections (WebPage.java:308)
> > at
> > wicket.markup.html.HtmlHeaderContainer.onComponentTagBody(HtmlHeaderContainer.java:119)
> > at wicket.Component.renderComponent(Component.java :1860)
> > at
> > wicket.markup.html.WebMarkupContainer.onRender(WebMarkupContainer.java:73)
> > at wicket.Component.render(Component.java:1145)
> > at wicket.MarkupContainer.autoAdd(MarkupContainer.java:168)
> > at
> > wicket.markup.html.HtmlHeaderResolver.resolve(HtmlHeaderResolver.java:76)
> > at
> > wicket.MarkupContainer.renderNext(MarkupContainer.java:1129)
> > at wicket.MarkupContainer.renderAll(MarkupContainer.java:762)
> > at wicket.Page.onRender(Page.java:761)
> > at wicket.Component.render(Component.java:1145)
> > at wicket.Page.doRender (Page.java:247)
> > at wicket.RequestCycle.respond(RequestCycle.java:866)
> > at wicket.RequestCycle.request(RequestCycle.java:404)
> > at
> > wicket.protocol.http.WicketServlet.doGet(WicketServlet.java :195)
> >
> > Gili
> >
> > Johan Compagner wrote:
> > > but that method can't be called because they go all through render()
> > > and render checks for visibility:
> > >
> > > if (!isVisible())
> > > {
> > > findMarkupStream().skipComponent();
> > > }
> > > else
> > > {
> > >
> > >
> > > So where does that call come from?
> > >
> > > On 9/12/05, *Gili* < [EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED] >
> > > <mailto:[EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED]>>> wrote:
> > >
> > >
> > > The testcases do pass, but the problem still remains. You
> > > should be
> > > able to reproduce this on your end. Add a component into a
> > page with
> > > setVisible(false), then add a breakpoint inside its
> > > onComponentTagBody()
> > > method and note that this will still get invoked and the tag
> > will get
> > > rendered by Component.renderComponent(final MarkupStream
> > markupStream)
> > >
> > > I think the bug is actually on Component line 1849
> > which reads:
> > >
> > > // Render open tag
> > > if (getRenderBodyOnly() == false)
> > > {
> > > renderComponentTag(tag);
> > > }
> > >
> > > Gili
> > >
> > > Juergen Donnerstag wrote:
> > > > that is correct and based on the test cases it should
> > work. Do the
> > > > test cases succeed on your pc?
> > > >
> > > > Juergen
> > > >
> > > > On 9/12/05, Gili <[EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED]>
> > > <mailto: [EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED]>>> wrote:
> > > >
> > > >> I think you understood me. What I am saying is that a
> > > component with
> > > >>isVisible()==false still shows up on the page. This isn't
> > supposed to
> > > >>happen, right?
> > > >>
> > > >>Gili
> > > >>
> > > >>Juergen Donnerstag wrote:
> > > >>
> > > >>>Not sure I understand what you. Previously setVisible did NOT
> > > prevent
> > > >>>the component from rendering. It simply got written into a
> > > >>>NullResponse. Due to user requests (you included) we
> > changed it.
> > > >>>Invisible components (incl. associated
> > AttributeModifiers) don't
> > > get
> > > >>>rendered at all now.
> > > >>>
> > > >>>Juergen
> > > >>>
> > > >>>On 9/12/05, Gili < [EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED]>
> > > <mailto: [EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED]>>> wrote:
> > > >>>
> > > >>>
> > > >>>>Hi,
> > > >>>>
> > > >>>> I've got a meta redirect tag. In older releases of
> > > Wicket, if I invoked
> > > >>>>setVisible(false) on the tag, its nested AttributeModifier
> > > would become
> > > >>>>invisible too. With RC1, the tag and its nested
> > > AttributeModifier are
> > > >>>>rendering even though its state is:
> > > >>>>
> > > >>>>redirectPage=[Component id = redirectPage, page =
> > > >>>> desktopbeautifier.web.contactus.Page, path =
> > > >>>>1:headerContributor:redirectPage.WebComponent, isVisible
> > = false,
> > > >>>>isVersioned = true]
> > > >>>>
> > > >>>> I can't see how this could be anything but a bug.
> > Any ideas?
> > > >>>>
> > > >>>>Gili
> > > >>>>--
> > > >>>> http://www.desktopbeautifier.com/
> > > >>>>
> > > >>>>
> > > >>>>-------------------------------------------------------
> > > >>>>SF.Net email is Sponsored by the Better Software
> > Conference & EXPO
> > > >>>>September 19-22, 2005 * San Francisco, CA * Development
> > > Lifecycle Practices
> > > >>>>Agile & Plan-Driven Development * Managing Projects &
> > Teams *
> > > Testing & QA
> > > >>>>Security * Process Improvement & Measurement *
> > > http://www.sqe.com/bsce5sf
> > > >>>>_______________________________________________
> > > >>>>Wicket-user mailing list
> > > >>>>[email protected]
> > <mailto:[email protected] >
> > > <mailto: [email protected]
> > <mailto:[email protected] >>
> > > >>>>https://lists.sourceforge.net/lists/listinfo/wicket-user
> > > < https://lists.sourceforge.net/lists/listinfo/wicket-user>
> > > >>>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>-------------------------------------------------------
> > > >>>SF.Net email is Sponsored by the Better Software
> > Conference & EXPO
> > > >>>September 19-22, 2005 * San Francisco, CA * Development
> > > Lifecycle Practices
> > > >>>Agile & Plan-Driven Development * Managing Projects &
> > Teams *
> > > Testing & QA
> > > >>>Security * Process Improvement & Measurement *
> > > http://www.sqe.com/bsce5sf
> > > >>>_______________________________________________
> > > >>>Wicket-user mailing list
> > > >>> [email protected]
> > <mailto: [email protected]>
> > > <mailto: [email protected]
> > <mailto:[email protected]>>
> > > >>> https://lists.sourceforge.net/lists/listinfo/wicket-user
> > > >>>
> > > >>
> > > >>--
> > > >> http://www.desktopbeautifier.com/
> > > >>
> > > >>
> > > >>-------------------------------------------------------
> > > >>SF.Net email is Sponsored by the Better Software
> > Conference & EXPO
> > > >>September 19-22, 2005 * San Francisco, CA * Development
> > Lifecycle
> > > Practices
> > > >>Agile & Plan-Driven Development * Managing Projects & Teams *
> > > Testing & QA
> > > >>Security * Process Improvement & Measurement *
> > > http://www.sqe.com/bsce5sf
> > > >>_______________________________________________
> > > >>Wicket-user mailing list
> > > >> [email protected]
> > <mailto: [email protected]>
> > > <mailto: [email protected]
> > <mailto: [email protected]>>
> > > >>https://lists.sourceforge.net/lists/listinfo/wicket-user
> > > >>
> > > >
> > > >
> > > >
> > > > -------------------------------------------------------
> > > > SF.Net email is Sponsored by the Better Software
> > Conference & EXPO
> > > > September 19-22, 2005 * San Francisco, CA * Development
> > Lifecycle
> > > Practices
> > > > Agile & Plan-Driven Development * Managing Projects & Teams *
> > > Testing & QA
> > > > Security * Process Improvement & Measurement *
> > > http://www.sqe.com/bsce5sf
> > > > _______________________________________________
> > > > Wicket-user mailing list
> > > > [email protected]
> > <mailto: [email protected]>
> > > <mailto:[email protected]
> > <mailto: [email protected]>>
> > > > https://lists.sourceforge.net/lists/listinfo/wicket-user
> > > >
> > >
> > > --
> > > http://www.desktopbeautifier.com/
> > >
> > >
> > > -------------------------------------------------------
> > > SF.Net email is Sponsored by the Better Software Conference &
> > EXPO
> > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> > > Practices
> > > Agile & Plan-Driven Development * Managing Projects & Teams *
> > > Testing & QA
> > > Security * Process Improvement & Measurement *
> > > http://www.sqe.com/bsce5sf
> > > _______________________________________________
> > > Wicket-user mailing list
> > > [email protected]
> > <mailto:[email protected]>
> > > <mailto: [email protected]
> > <mailto:[email protected]>>
> > > https://lists.sourceforge.net/lists/listinfo/wicket-user
> > >
> > >
> >
> > --
> > http://www.desktopbeautifier.com/
> >
> >
> > -------------------------------------------------------
> > SF.Net email is Sponsored by the Better Software Conference & EXPO
> > September 19-22, 2005 * San Francisco, CA * Development Lifecycle
> > Practices
> > Agile & Plan-Driven Development * Managing Projects & Teams *
> > Testing & QA
> > Security * Process Improvement & Measurement *
> > http://www.sqe.com/bsce5sf
> > _______________________________________________
> > Wicket-user mailing list
> > [email protected]
> > <mailto:[email protected]>
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> > <https://lists.sourceforge.net/lists/listinfo/wicket-user>
> >
> >
>
> --
> http://www.desktopbeautifier.com/
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Wicket-user mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user
