May be I'm wrong, but I think it does not solve the problem. The current exception messages says "Markup of type 'html' for component 'wicket.markup.html.basic.SimplePage' not found or invalid". => (the last two words: OR INVALID). And the the causing exception say exactly which tag, which file, while line etc. I guess the problem is that it is not clear / obvious enough. All information are there, but obviously not presented well enough. E.g. in case of <span> example, the root exception should be passed to the top and not be casted into an exception saying markup could not be found or is invalid. And handling this situations is made more easy with additional exception classes.
One more idea: I think it is Spring, they simply concatenate the root cause at the end of the new message. E.g. "Markup could not be found ... cause by: span tag not matched ... ". A single large message. Thus people don't have to search down the stacktrace (which of course provides the same information already). Jürgen On 10/26/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > How about: > > MarkupNotFoundException - this is pretty clear. Message should say something > like it does now: Markup for component x not found. > > MarkupParseException - this is when there is a problem with parsing the html > template. The message should name the filename and say exactly where in that > file the problem is. > > InvalidMarkupException - gets throw when there is a wicket-releated markup > problem. Ie a component is attached to a tag it does not support. The > message should be something like: component x does not support markup tag of > type y, or something similar. > > -Igor > > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf Of > > Eelco Hillenius > > Sent: Tuesday, October 25, 2005 3:04 PM > > To: wicket-user@lists.sourceforge.net > > Subject: Re: [Wicket-user] Markup not found > > > > Sounds like a good idea. > > > > Eelco > > > > > > On 10/25/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > > > Maybe we should consider expanding our exception hierarchy a bit. > > > Currently we only have the WicketRuntimeException and > > MarkupException. > > > Maybe we can introduce MarkupNotFoundException and > > > MarkupInvalidException with their own specialized messages. > > Sometimes > > > the cause of the exception is so far down it is hard to find or it > > > simply gets cut off, im for putting the most specific > > message into the > > > exception's message instead of leaving it to the user to > > find in the deepest cause. > > > > > > -Igor > > > > > > > > > > > > ________________________________ > > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED] On Behalf > > Of Francis > > > Amanfo > > > Sent: Tuesday, October 25, 2005 2:40 PM > > > To: wicket-user@lists.sourceforge.net > > > Subject: Re: [Wicket-user] Markup not found > > > > > > > > > This "Markup not found" exception thing is extremely misleading and > > > think needs addressing if Wicket is seriously aiming at going > > > mainstream. In my early days of Wicket I struggled so much > > with it. It > > > can happen because the markup really doesn't exist but also > > sometimes > > > when there is an error in your markup that wicket can't > > really point > > > to, in others words can't parse the xhtml. Only when Wicket > > can point > > > to the error wil it tell you there is an error in your html by > > > pointing directly to where the error is. I think the exceptions > > > catching in wicket core could do better. If this is not > > considered to > > > be addressed at the framework core, then I think we should start > > > compiling scenarios from our own experiences when this > > exception was thrown. This could save newbies to Wicket a lot > > of frustrations and time. > > > > > > Francis > > > > > > > > > On 10/25/05, Nick Heudecker <[EMAIL PROTECTED]> wrote: > > > > I've been staring at this for hours, but can't figure out > > what would > > > > cause > > > a "Markup not found" error when the markup does in fact > > exist at the > > > correct location. What other error conditions could cause > > this problem? Thanks. > > > > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by the JBoss Inc. > > Get Certified Today * Register for a JBoss Training Course > > Free Certification Exam for All Training Attendees Through > > End of 2005 Visit http://www.jboss.com/services/certification > > for more information _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by the JBoss Inc. > Get Certified Today * Register for a JBoss Training Course > Free Certification Exam for All Training Attendees Through End of 2005 > Visit http://www.jboss.com/services/certification for more information > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > ------------------------------------------------------- This SF.Net email is sponsored by the JBoss Inc. Get Certified Today * Register for a JBoss Training Course Free Certification Exam for All Training Attendees Through End of 2005 Visit http://www.jboss.com/services/certification for more information _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
