Uh, I forgot, PdfDataSource is final, so option B is not even an option now ;)

Matej Knopp wrote:
Btw, there's a problem with current implementation. After the report is done, you can't generated another report (e.g. clicking twice on the same link). Because datasource is the same and it's at the end. So all further calls to datasource.next() will result in false.

The solution now is either:

a) having datasource that can automatically rewind - not a big deal, but perhaps problem when you have result set data source

 b) using getDataSource as data source factory.

I think there should be more explicit way to specify data source factory than overriding getDataSource. Or at least it should be mentioned in the javadoc?

Any ideas?

-Matej

Matej Knopp wrote:

Checked it out, I really like it. Mine was just a quick hack ;)

-Matej

Eelco Hillenius wrote:

Thanks. Much better now. I implemented a couple of small changes on
top of it, please check out whether you agree (find the patch
attached).

Eelco


Matej Knopp wrote:

Hi.

There's a slight performace problem with JRResource, that it creates
JasperReport in it's constructor. I've 10 resource links on one page so
it means that 10 JasperReports will be initialized everytime page is
created, even if none of them gets clicked. The performance penalty is
not small - 400ms.
So I think the JasperReport should be initialized lazyly, only when
the  resource is really used.
I've atached "fixed" JRResource, it may not be the best solution, but
it works for me. (Look in the constructor(s) to see how it works)

-Matej





-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user




-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to