On Wed, 7 Dec 2005 17:38:13 -0800, Igor Vaynberg <[EMAIL PROTECTED]> wrote:

On 12/7/05, Christian Essl <[EMAIL PROTECTED]> wrote:

Or you can implement your own Page{addPublicStateChange()} ;)



Lets first agree that this is needed and we are going to implement it in
wicket,

I do agree would be nice to have a vote between you core-develpers, because it gets quite in the center?



but the model will not be in the detached state. we use Object=
model.getModelObject() so that attaches the model and then we clone the
returned object if the model doesnt implement the IModelObjectVersionable.
This is bad default behaviour because detachable models are usually pull
models and so we should not version their model objects. currently this is
not a problem because we clone the model and the object it links to is
transient.

i guess this is really a non-issue because most of the time you do not call setmodelobject on a detachable model :) but it is def something to watch out
for, imagine if the model is for a hibernate object and you start
serializing it - serialize the whole object graph. we do provide a way to
break out of this so maybe its not a huge deal.


I did now a type-hierarchy on IModel and I found that for the majority of models it makes no sense to version their objects or is not possible the way we do it. As I found by fast browsing only the PropertyModels and the wicket.model.Model (and the old dataview.table.LenientModelWrapper) would be good candidates. The extensions..beanedit..BeanModel could use versioning but does not support setObject(). So I'd say have the versioning by default off only if the IModel implements IModelObjectVersionable. But please see yourself.

Christian

        

        
                
___________________________________________________________ Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to