Yes, thats good and we make onRender (not doRender) deprecated. Thus
every user will have time to change his code.
Juergen
On 1/9/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> can't we keep both?
>
> doRender()
> {
> doRender(findMarkupStream());
> }
>
> and move everything of the current do render to that one with the param.
>
> johan
>
>
>
> On 1/9/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
> > I'm +1. But I'm fully into Ajax development mode currently ;-)
> >
> > Martijn
> >
> >
> > On 1/8/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
> > > Currently onRender does not take and not respond any parameter
> > > protected abstract void onRender();
> > > I'd like to change it to
> > > protected abstract void onRender(MarkupStream markupStream);
> > >
> > > Reason: currently we do findMarkupStream at least twice. Once inside
> > > Component.renderComponent() and due to a recent improvement which
> > > allows to re-render previously invisible component within render() as
> > > well. Due to the latter the markup stream is known when we call
> > > onRender(). And, IMO more important, I did never really like that I
> > > have to call findMarkupStream inside onRender(). For me it is the
> > > important parameter for onRender and should be passed via a parameter.
> > > That is far more obvious than to call findMarkupStream.
> > > However the change breaks the publiv API and most likely some user
> > > developed components. The question is, shall we make that change? I
> > > think we should. We did change the API already for 1.2 and this change
> > > just adds to it.
> > >
> > > Juergen
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> files
> > > for problems? Stop! Download the new AJAX search engine that makes
> > > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> > > http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
> > > _______________________________________________
> > > Wicket-user mailing list
> > > Wicket-user@lists.sourceforge.net
> > >
> https://lists.sourceforge.net/lists/listinfo/wicket-user
> > >
> >
> >
> > --
> > Living a wicket life...
> >
> > Martijn Dashorst - http://www.jroller.com/page/dashorst
> >
> > Wicket 1.1 is out:
> http://wicket.sourceforge.net/wicket-1.1
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> files
> > for problems? Stop! Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> > http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
> > _______________________________________________
> > Wicket-user mailing list
> > Wicket-user@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> >
>
>
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
