You will not be able to see the difference between optimalization...
String.equals() does exactly that, it test for length

and where we just do this "".equals(value) without testing for null
i will not rewrite those by first testing null to be able to call for length.


On 9/21/06, Erik van Oosten <[EMAIL PROTECTED]> wrote:
If this gets accepted, may I humbly suggest to replace

  value != null && !"".equals(value)

with

  value != null && value.length() != 0

The latter performs considerably faster (though it is of course still a
micro optimization).

Regards,
     Erik.


--
Erik van Oosten
http://www.day-to-day-stuff.blogspot.com/


Manuel Barzi schreef:
> Ok, Igor, I already solved this issue by re-implementing Link class in
> my custom LinkButton class, just adding the following snippet
> extracted from Button class, and added to the original
> "onComponentTag" Link in this new LinkButton class:
>
> ---
> // Default handling for tag
>               super.onComponentTag(tag);
>
>               // manuelbarzi {
>               // setting the "value" property to the tag
>               try {
>                       String value = getModelObjectAsString();
>                       if (value != null && !"".equals(value)) {
>                               tag.put("value", value);
>                       }
>               } catch (Exception e) {
>                       // ignore.
>               }
>               // }
>
>               // Set href to link to this link's linkClicked method
> ---
>
> It works fine now. May this simple addition be interesting for other
> people needing this functionality, you'll judge according to
> statistics...
>
> Thank you and regards,
>
> Manu
>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to