its reverted
-igor
On 12/12/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
On 12/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> yeah i changed it, didnt think anyone was using this particular facet.
We use it also.
> im not sure if we should put it back. the problem is sometimes you can
paint
> yourself into a nasty corner. if you have a component that uses a
hardcoded
> id, and later the user of that component uses it twice in a page, or
puts it
> into a repeater you will have duplicate ids in html which is not legal,
and
> whats worse is it will break ajax/js/css but it will be very hard to
track
> down.
Most of the time you are in full control of the markup id. In my
experience it is in a rare occaission that you have to worry about
reuse. Repeaters, listview are tricky, and for those I typically let
Wicket generate the markup id using setOutputMarkupId.
So -1 for not honoring existing markup ids.
Martijn
> On 12/11/06, Caleb Land <[EMAIL PROTECTED]> wrote:
> > I've been using 2.0-SNAPSHOT for a while now and I noticed a behavior
> > recently that is new. If I have an HTML id defined in my markup:
> >
> > <wicket:panel>
> > <div id="labels" wicket:id="labels"></div>
> > </wicket:panel>
> >
> > When the panel is rendered the HTML id attribute is replaced with
> > something that is generated by Wicket like "labels40".
> >
> > I looked through the svn changelog for MarkupContainer and noticed
> > that the getMarkupId() method has been changed, and the javadoc for
> > that method that said:
> >
> > "If the id attribute is present in the markup attributes of this
component
> > it will be used, otherwise the page-relative path of this component
will
> > be used."
> >
> > has been deleted...
> >
> > Should I be able to hard code HTML ids in the future or was that
> > "feature" removed? I used hard coded HTML ids in my Page markup files
> > I sometimes use HTML ids to reference elements from CSS and javascript
> > and I had to use a class instead because of these generated Ids.
> >
> > --
> > Caleb Land
> > ([EMAIL PROTECTED])
> >
> >
>
-------------------------------------------------------------------------
> > Take Surveys. Earn Cash. Influence the Future of IT
> > Join SourceForge.net's Techsay panel and you'll get the chance to
share
> your
> > opinions on IT & business topics through brief surveys - and earn cash
> >
>
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> > _______________________________________________
> > Wicket-user mailing list
> > Wicket-user@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> >
>
>
>
-------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
your
> opinions on IT & business topics through brief surveys - and earn cash
>
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>
> _______________________________________________
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>
>
>
--
Vote for Wicket at the
http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.3 is as easy as 1-2-3. Download Wicket now!
http://wicketframework.org
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
