First we need to know why the file needs to be there. Is there any reason for the dtd to be in the root directory of the distribution, or can it reside in another location? Is the dtd actually something we support, and something that works?
Second, if we decide that it should be there, then we have to make sure the maven assembly plugin copies the file into the final distribution. Third, the ant build file exists only for convenience. I want to include it, but not maintain it. So if the ant build is breaking regularly, then I'm more inclined to remove it altogether and only supply the maven build. Adding more steps to building the release is something I'm very -1 on. Building a release already takes 1 whole day. Martijn On 1/3/07, Iman Rahmatizadeh <[EMAIL PROTECTED]> wrote: > > On 1/3/07, Frank Bille <[EMAIL PROTECTED]> wrote: > > Well it's actually my fault. When I created that unit test I assumed that > we inclueded wicket-xhtml1-strict.dtd in the release. You should be fine > just putting the a file in the root directory (C:\workspace\wicket-1.2.3 ) > and call it wicket-xhtml1-strict.dtd. It's not the content that matters but > that that is somewhat big. > > Although unit tests shouldn't rely on external files, I guess you have no > choice here. Can you create the file on the fly and delete it afterwards ? > Or maybe somehow mock the file access thingy ? > > I'll fix this in the different releases. Martijn perhaps we should include > a step in the release process that tests the release (run ant jar or > something)? > > +1 > > > > > Frank > > > > > > > > > > On 1/3/07, TH Lim <[EMAIL PROTECTED] > wrote: > > > > > > I am compiling wicket-1.2.3 from the zip file using "ant jar" and the > > > compilation was terminated unsuccessfully with the message "[junit] File > > > does not exists. You must provide an existing file: > > > C:\workspace\wicket-1.2.3\wicket-xhtml1-strict.dtd". I found > > > wicket-1.0-xhtml11.dtd in the directories src\site\resources\DTD and > > > docs\DTD. Should rename wicket-1.0-xhtml11.dtd to > wicket-xhtml1-strict.dtd > > > and placed it to my local directory C:\workspace\wicket- 1.2.3? Please > > > advise. > > > > > > > > > Martijn Dashorst wrote: > > > > > > > > We don't use ant ourselves. The dtd file should be in the root > > > > directory of the zip. Apparently the assembly descriptor used to build > > > > the download archive didn't pick it up. grmbl. > > > > > > > > You can get the dtd from svn or use the one supplied in the > wicket-1.2.3 > > > > zip. > > > > > > > > It hasn't been updated for a while (read 1 year or so). > > > > > > > > Martijn > > > > > > > > On 1/2/07, Iman Rahmatizadeh <[EMAIL PROTECTED] > wrote: > > > >> Hmmm, anyone ? > > > >> Can anybody pass the tests on wicket-1.2.4 with ant ? I'm using > building > > > >> a > > > >> fresh distro with ant and the testInternalDetach test fails. Its > looking > > > >> for > > > >> the wicket-xhtml1-strict.dtd file and can't find it . > > > >> > > > >> > > > >> On 1/1/07, Iman Rahmatizadeh <[EMAIL PROTECTED]> wrote: > > > >> > The FileUploadFieldTest try's to upload a non-existent file ( > > > >> wicket-xhtml1-strict.dtd ) Where should this file be ? I'm testing > using > > > >> ant > > > >> jar task. > > > >> > > > > >> > Iman > > > >> > > > > >> > > > >> > > > >> > ------------------------------------------------------------------------- > > > >> Take Surveys. Earn Cash. Influence the Future of IT > > > >> Join SourceForge.net's Techsay panel and you'll get the chance to > share > > > >> your > > > >> opinions on IT & business topics through brief surveys - and earn > cash > > > >> > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > >> > > > >> _______________________________________________ > > > >> Wicket-user mailing list > > > >> [email protected] > > > >> > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > >> > > > >> > > > >> > > > > > > > > > > > > -- > > > > Vote for Wicket at the > > > > http://www.thebeststuffintheworld.com/vote_for/wicket > > > > Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! > > > > http://wicketframework.org > > > > > > > > > ------------------------------------------------------------------------- > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > share > > > > your > > > > opinions on IT & business topics through brief surveys - and earn cash > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > _______________________________________________ > > > > Wicket-user mailing list > > > > [email protected] > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > -- > > > View this message in context: > http://www.nabble.com/1.2.4%3A-Test-cannot-find-file-tf2904045.html#a8139504 > > > Sent from the Wicket - User mailing list archive at Nabble.com. > > > > > > > > > > ------------------------------------------------------------------------- > > > Take Surveys. Earn Cash. Influence the Future of IT > > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > > opinions on IT & business topics through brief surveys - and earn cash > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > _______________________________________________ > > > Wicket-user mailing list > > > [email protected] > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > ------------------------------------------------------------------------- > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > opinions on IT & business topics through brief surveys - and earn cash > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > _______________________________________________ > > Wicket-user mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > Wicket-user mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
