Ok, I guess just not escaping would be fine is most if not all cases. Eelco
On 1/19/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > i dont know if we need yet another setting/attribute > > lets go the simple route and have them always not escaped first, then if > someone wants it thats fine. do we need to have a vote on this? > > -1 on a setting for sure, if i design a component to work in one setting and > you drop it into a project that uses another it will break. so an attribute > maybe - upon a request. setting def not. > > as far as wicket:message property - yes those should always be escaped - > there is no reason to embed markup in an attribute afaict > > -igor > > > > On 1/19/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > Yeah. It would probably be a better default. It would be best if you > > could at least override this default with an attribute on the > > wicket:message tag, and maybe as a global setting as well. What about > > wicket:message attributes though (actually, I didn't know they were > > working yet): those should probably always be escaped? > > > > Eelco > > > > > > On 1/19/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > i guess maybe we should allow markup in wicket:message since it comes > from > > > .property files so no security threat. > > > > > > what do others think? > > > > > > > > > -igor > > > > > > > > > On 1/19/07, Peter Thomas <[EMAIL PROTECTED] > wrote: > > > > Yes, that would be great and I'll watch out for when it is released ! > > > > > > > > I am also wondering if this can be "globally" set (maybe slight > > > performance improvement?) but you will be the best judge for that. > > > > > > > > > > > > Thanks, > > > > > > > > Peter. > > > > > > > > > > > > On 1/19/07, Igor Vaynberg < [EMAIL PROTECTED]> wrote: > > > > > if you want to upgrade to 1.x (1.3) i can try adding a switch to > > > wicket:message to disable escaping > > > > > > > > > > > > > > > -igor > > > > > > > > > > > > > > > > > > > > On 1/19/07, Peter Thomas < [EMAIL PROTECTED]> wrote: > > > > > > I am using 1.2.4 > > > > > > > > > > > > Not sure if it matters but I'm using a Spring MessageSource so I > have > > > my own implementation of IStringResourceLoader set up in the Application > > > through "getResourceSettings().addStringResourceLoader" > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Peter. > > > > > > > > > > > > > > > > > > > > > > > > On 1/19/07, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > > > > what version of wicket are you using? > > > > > > > > > > > > > > -igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 1/19/07, Peter Thomas < [EMAIL PROTECTED]> wrote: > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > I'm migrating a JSP app which already has i18n to wicket and > > > re-using an existing resource bundle. There are a few cases where HTML > has > > > been embedded in the string resource - e.g: > > > > > > > > > > > > > > > > my.key=Hello<br/>World! > > > > > > > > > > > > > > > > But now when using <wicket:message key="my.key "/> wicket > appears > > > to be html escaping the value of the localized string retrieved - so in > this > > > case I see the "<br/>" rendered on screen where I expected a line break. > > > > > > > > > > > > > > > > Is there any way to suppress this or there is no option but to > > > clean up the bundles? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > Peter. > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > > > > > Join SourceForge.net's Techsay panel and you'll get the chance > to > > > share your > > > > > > > > opinions on IT & business topics through brief surveys - and > earn > > > cash > > > > > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > Wicket-user mailing list > > > > > > > > Wicket-user@lists.sourceforge.net > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > > > > Join SourceForge.net's Techsay panel and you'll get the chance > to > > > share your > > > > > > > opinions on IT & business topics through brief surveys - and > earn > > > cash > > > > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > > > > > > > > > > _______________________________________________ > > > > > > > Wicket-user mailing list > > > > > > > Wicket-user@lists.sourceforge.net > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > > > share your > > > > > > opinions on IT & business topics through brief surveys - and earn > cash > > > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > > > > > > > > _______________________________________________ > > > > > > Wicket-user mailing list > > > > > > Wicket-user@lists.sourceforge.net > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > share > > > your > > > > > opinions on IT & business topics through brief surveys - and earn > cash > > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > > > > > > _______________________________________________ > > > > > Wicket-user mailing list > > > > > Wicket-user@lists.sourceforge.net > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > share > > > your > > > > opinions on IT & business topics through brief surveys - and earn cash > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > > > > _______________________________________________ > > > > Wicket-user mailing list > > > > Wicket-user@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > Take Surveys. Earn Cash. Influence the Future of IT > > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > > opinions on IT & business topics through brief surveys - and earn cash > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > > > _______________________________________________ > > > Wicket-user mailing list > > > Wicket-user@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > opinions on IT & business topics through brief surveys - and earn cash > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
