Nice to see someone tackling the remaining warnings. :) I leave reviewing the code to someone better suited for the task, but here's a few comments:
Could you elaborate a bit more on the warnings which are silenced? For minizip and similar I fully understand since we don't want to diverge from upstream (and ideally shouldn't need to include them), however I wonder about the rest. Regarding the silencing macro, it seems nice and straight-forward to use. However, the original (http://dbp-consulting.com/tutorials/SuppressingGCCWarnings.html) doesn't seem to mention a license nor terms of use for it. Any thoughts on this? At any rate I assume it would be considered a derivate work of the original, which could cause all sorts of problems. Maybe I'm overreacting a bit, but I would like to see that clarified a bit more. -- https://code.launchpad.net/~hono/widelands/warnings/+merge/142035 Your team Widelands Developers is requested to review the proposed merge of lp:~hono/widelands/warnings into lp:widelands. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
