I only reviewed the code from the technical point of view and from there it looks fine. I am also not concerned about the individual disabling of the warnings in the code - it was all clear to me when I reviewed it.
About the copyright issue - the text seems to have been written/dublicated into the boost wiki as a coding reference for the boost libraries [1]. I therefore feel they are basically part of the c++ folklore and therefore free to use - and we give credit in the code. I am not a lawyer, but as long as no one complains, I think we are golden. https://svn.boost.org/trac/boost/wiki/Guidelines/WarningsGuidelines -- https://code.launchpad.net/~hono/widelands/warnings/+merge/142035 Your team Widelands Developers is requested to review the proposed merge of lp:~hono/widelands/warnings into lp:widelands. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
