In terms of warnings silenced rather than fixed through code change, this was 
only done where no code change was desirable (the minizip and lua code), or 
possible (macros from headers outside of Widelands, e.g. GLEW_VERSION_1_4, 
htons(), ioctl-related constants).

All other warnings were fixed through code change.



Here is a thread from the original author, Jonathan Wakely, who is referenced 
on the Boost page and on the page I referenced in code:

http://gcc.gnu.org/ml/gcc-help/2011-01/msg00135.html

    > Also, can I steal, with attribution of course, GCC_DIAG_OFF/ON(x)?
    Certainly.

The main difference between that GCC_DIAG_OFF/ON and the one I committed was he 
has:
  GCC_DIAG_OFF(old-style-cast)

I have:
  GCC_DIAG_OFF("-Wold-style-cast")

Why? My version doesn't get complained at by the CodeCheck (it complained about 
lack of a space after an operator)
-- 
https://code.launchpad.net/~hono/widelands/warnings/+merge/142035
Your team Widelands Developers is requested to review the proposed merge of 
lp:~hono/widelands/warnings into lp:widelands.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to