1. Never got warm with doxygen. The comments are so verbose in the source code 
and the html help does not add much for me. I prefer well documented headers a 
lot more - and you can look at them in doxygen as well.

2. cstdint is not part of this rule - some compilers ship it, but most don't. 
Mine doesn't.

3. Good catch. I found some more of these.

4. I wanted to work towards a design without a g_gr. I gave in at one point 
though :).

5. Fixed. Writing this really showed what a do-all-does-all kind of class 
Graphic really is.

6. I motted out my old gcc and ran it. Fixed all of the new warnings.

All fixes are in the common branch. Thanks for the reviews - if you have more 
comments keep them coming. I will go ahead and merge the common branch tonight 
though, because I might be pressed on time this week. I will adress other 
comments in trunk as well though.
-- 
https://code.launchpad.net/~sirver/widelands/autocache/+merge/147559
Your team Widelands Developers is requested to review the proposed merge of 
lp:~sirver/widelands/autocache into lp:widelands.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to