Not all of these are uncritical, i.e. std::string name = r.String(); will read 
bytes from r., removing the variable is fine, but the r.String(); must remain 
(with a comment).

-- 
https://code.launchpad.net/~hjd/widelands/cppcheck-issues/+merge/198154
Your team Widelands Developers is requested to review the proposed merge of 
lp:~hjd/widelands/cppcheck-issues into lp:widelands.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to