Thanks for the comments, of course i only wanted a review, not a merge in the current state. This are my first steps with go, so i am just glad that it works at all ;).
- i will add tests - the irc library handles disconnects itself, and because of the use of a callback function for irc->lobby it is already decoupled. I disconnected from the internet to test and it automatically reconnected and the lobby was still usable. But i will look into using a routine and buffers... - pointer recievers: Here i am really unsure, but i've found: A method is a function with an implicit first argument, called a receiver. So when you call a method: - if the receiver is a pointer to int, it copies the pointer to int. - if the receiver is a struct, it copies the struct. - if the receiver is a pointer to struct, it copies the pointer to struct. So even if i don't want to modify the struct i would think avoiding a copy operation by passing a pointer to the struct should be faster? But here speaks only 1 day go experience... ;) -- https://code.launchpad.net/~widelands-dev/widelands-metaserver/ircbridge/+merge/203277 Your team Widelands Developers is subscribed to branch lp:widelands-metaserver. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
