All right you probably said it, I am not arguing... two comments to latest revision:
a) animation.cc - I reverted this file to status in trunk, I am not able to fix it properly, I just needed to prevent crashes when testing AI b) in regard to this: NOCOM(#tiborb): move this safe_ware_index() to the intitalization of the AI to blow up early. I made no change as I think it is done on right place, it is indeed part of initialization of AI (=done once in game) Tibor 2014-07-12 14:53 GMT+02:00 SirVer <[email protected]>: > Review: Needs Fixing > > It annoys me telling you the same things again (like not including > SDL_types.h which I think I did two times before or removing the Default AI > comment).... but I will do it one more time. This time I did it as inline > comments, so that it will not get lost in the review process. Please fix > this so that we can merge. > -- > https://code.launchpad.net/~widelands-dev/widelands/tibor-ai4/+merge/226029 > Your team Widelands Developers is subscribed to branch > lp:~widelands-dev/widelands/tibor-ai4. > > _______________________________________________ > Mailing list: https://launchpad.net/~widelands-dev > Post to : [email protected] > Unsubscribe : https://launchpad.net/~widelands-dev > More help : https://help.launchpad.net/ListHelp > -- https://code.launchpad.net/~widelands-dev/widelands/tibor-ai4/+merge/226029 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/tibor-ai4. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
