Review: Needs Fixing Hi, I did some quick testing of this patch. I found that if any mine is selected, I get a similar crash when attempting to save. I guess that needs a similar fix.
I saw some crashes when selecting dismantling site and then something else, but those might have been caused by the other building happening to be a mine. Hard to tell, but I can check again once that's fixed. I only skimmed the code changes, but thumbs up for replacing the if statements with a switch, :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1455732/+merge/259326 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1455732. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
