Great achievement. Is there an API so that bunnybot can check for the appveyor 
build state too? (I can search for it myself, but maybe you already know where 
it is). One inline comment with food for thought.

Diff comments:

> 
> === modified file 'utils/detect_revision.py'
> --- utils/detect_revision.py  2015-07-23 10:46:52 +0000
> +++ utils/detect_revision.py  2016-01-06 18:28:17 +0000
> @@ -44,7 +44,11 @@
>  def detect_git_revision():
>      if not sys.platform.startswith('linux') and \
>         not sys.platform.startswith('darwin'):
> -        return None
> +        git_revnum=os.popen('git show --pretty=format:%h | head -n 
> 1').read().rstrip()
> +        if git_revnum:
> +            return 'unofficial-git-%s' % (git_revnum,)

that is rather unhealthy.... If we get bug reports against official builds, we 
have to inverse the bzr -> git mapping manually. I do not know how to solve it 
better though.

> +        else:
> +            return None
>  
>      is_git_workdir=os.system('git show >/dev/null 2>&1')==0
>      if is_git_workdir:


-- 
https://code.launchpad.net/~widelands-dev/widelands/appveyor/+merge/281599
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/appveyor.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to