Review: Approve

Tho code look good, sorry for introducing this bug.


About the resource-editing thing: Strictly speaking I think the behaviour is 
consistent.

The analogous feature of "remove immovable" in terms of resources is "set 
resource to 0". This works even if you have a different resource selected. The 
decrease/increase resource has no equivalent.

After a little bit of testing I also think the current increase/decrease 
behaviour makes sense. Imaging you have several resource sitting next to 
another. If you have a bigger tool size and start to reduce resources, it 
should only affect the resource you have selected. If we change the behaviour 
to allow decreasing any resource, at least in my scenario this will lead to 
unexpected results.



-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/fix_overlays.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to