Review: Approve

> We have this string as a part of a bunch of regex and it gets repeated, so I 
> was wondering if it made the code more readable to extract that part into a 
> string variable.

I think it is django style to repeat this over and over again. I suggest 
leaving it that way.

Code lgtm. Kaputtnik, can you do the rollout of this? We can also do it 
together on the weekend if you'd prefer.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/add_hints/+merge/285664
Your team Widelands Developers is subscribed to branch lp:widelands-website.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to