Review: Approve

one comment inline, but I think this can go in the way it is.

Diff comments:

> 
> === modified file 'src/wlapplication.cc'
> --- src/wlapplication.cc      2016-08-13 12:16:14 +0000
> +++ src/wlapplication.cc      2016-09-16 16:56:31 +0000
> @@ -575,6 +588,20 @@
>               default:;
>               }
>       }
> +
> +     // Now constructing the events for the Alt key from the container and 
> handling them.

technically, this reoders the events. But lets go with this as long as it does 
not make any troubles.

> +     for (const auto& event : alt_events) {
> +             ev.type = event.second;
> +             ev.key.keysym.sym = event.first.first;
> +             ev.key.keysym.mod = event.first.second;
> +             bool handled = false;
> +             if (cb && cb->key) {
> +                     handled = cb->key(ev.type == SDL_KEYDOWN, 
> ev.key.keysym);
> +             }
> +             if (!handled) {
> +                     handle_key(ev.type == SDL_KEYDOWN, ev.key.keysym.sym, 
> ev.key.keysym.mod);
> +             }
> +     }
>  }
>  
>  /*


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1616661_messagebox_hotkeys/+merge/305381
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to