Review: Approve
Code LGTM, just 1 nit. Not tested.
Diff comments:
>
> === modified file 'src/wui/field_overlay_manager.cc'
> --- src/wui/field_overlay_manager.cc 2016-12-03 12:51:06 +0000
> +++ src/wui/field_overlay_manager.cc 2016-12-09 10:05:43 +0000
> @@ -39,7 +39,8 @@
> Vector2i(buildhelp_info->pic->width() / 2,
> buildhelp_info->pic->height() - 1);
>
> const OverlayInfo* const buildhelp_infos_end = buildhelp_info +
> Widelands::Field::Buildhelp_None;
> - for (;; ++buildhelp_info, ++filename) { // The other buildhelp
> overlays.
> + for (;;) { // The other buildhelp overlays.
> + ++buildhelp_info, ++filename;
In order to avoid compiler warnings, please change this to:
++buildhelp_info;
++filename;
> if (buildhelp_info == buildhelp_infos_end)
> break;
> buildhelp_info->pic = g_gr->images().get(*filename);
--
https://code.launchpad.net/~widelands-dev/widelands/hotspot_fixes/+merge/312896
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/hotspot_fixes.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
