Review: Approve
code lgtm.
Diff comments:
> === modified file 'src/ui_basic/multilinetextarea.cc'
> --- src/ui_basic/multilinetextarea.cc 2016-10-29 06:41:42 +0000
> +++ src/ui_basic/multilinetextarea.cc 2016-12-01 20:48:08 +0000
> @@ -158,11 +158,11 @@
> uint32_t blit_height = std::min(text_im->height(),
> static_cast<int>(get_inner_h()));
>
> if (blit_width > 0 && blit_height > 0) {
> - float anchor = 0.f;
> + float anchor = 0;
I think this should be an int now since in this function you force it to be one.
> Align alignment = mirror_alignment(align_);
> switch (alignment & UI::Align::kHorizontal) {
> case UI::Align::kHCenter:
> - anchor = (get_eff_w() - blit_width) / 2.f;
> + anchor = (get_eff_w() - blit_width) / 2;
> break;
> case UI::Align::kRight:
> anchor = get_eff_w() - blit_width -
> RICHTEXT_MARGIN;
--
https://code.launchpad.net/~widelands-dev/widelands/actionconfirm_improvements/+merge/312301
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/actionconfirm_improvements.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
