Review: Approve

one nit, otherwise lgtm. not tested, but should be fine. 

Diff comments:

> === modified file 'src/editor/ui_menus/player_menu.cc'
> --- src/editor/ui_menus/player_menu.cc        2017-01-21 09:41:07 +0000
> +++ src/editor/ui_menus/player_menu.cc        2017-01-23 12:20:29 +0000
> @@ -169,7 +169,7 @@
>               }
>  
>               plr_set_tribes_buts_[p - 1]->set_title(
> -                eia().egbase().tribes().tribeinfo(selected_tribes_[p - 
> 1]).descname);
> +                Widelands::tribeinfo(selected_tribes_[p - 1]).descname);

get_tribe_info?

>  
>               // Set default AI and closeable to false (always default - 
> should be changed by hand)
>               map.set_scenario_player_ai(p, "");


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1512076-cleanup-static/+merge/315350
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1512076-cleanup-static.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to