Code still LGTM, 1 nit.
Diff comments:
> === modified file 'src/network/internet_gaming.cc'
> --- src/network/internet_gaming.cc 2017-11-30 20:45:41 +0000
> +++ src/network/internet_gaming.cc 2018-01-10 19:08:53 +0000
> @@ -800,8 +805,18 @@
> _("Message could not be sent: Was this supposed to
> be a private message?"));
> return;
> }
> + std::string recipient = msg.substr(1, space - 1);
> + for (const InternetClient& client : clientlist_) {
> + if (recipient == client.name && client.build_id ==
> "IRC") {
> + format_and_add_chat(
> + "", "", true,
> + _("Private message to IRC users are not
> supported."));
Private message -> Private messages
> + return;
> + }
> + }
> +
> s.string(trimmed); // message
> - s.string(msg.substr(1, space - 1)); // recipient
> + s.string(recipient); // recipient
>
> format_and_add_chat(clientname_, msg.substr(1, space - 1),
> false, msg.substr(space + 1));
>
--
https://code.launchpad.net/~widelands-dev/widelands/irc_users/+merge/335898
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/irc_users.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
