Review: Approve
*waves to SirVer*
Can we disallow usernames with "." or "@" in them? Allowing ' would be good,
since that character is used in real-world names.
I had a look at the diff as far as Launchpad will display it. Just 1 potential
nit.
Since the alpha site is already switched off, I haven't done any testing.
> 14. optionally drop the database tables related to tracking called:
> tracking_bannedip, tracking_untrackeduseragent, tracking_visitor
We should definitely do this once we're sure that everything's OK.
Diff comments:
>
> === modified file 'settings.py'
> --- settings.py 2017-12-23 09:15:02 +0000
> +++ settings.py 2018-04-14 15:03:53 +0000
> @@ -311,12 +310,21 @@
> BLEACH_ALLOWED_ATTRIBUTES = {'img': ['src', 'alt'], 'a': [
> 'href'], 'td': ['align'], '*': ['class', 'id', 'title']}
>
> -################################
> -# Pagination settings #
> -# for linaro-django-pagination #
> -################################
> +##########################
> +# Pagination settings #
> +# for dj-pagination #
> +##########################
> PAGINATION_DEFAULT_WINDOW = 2
>
> +###########################
> +# Settings for displaying #
> +# online users #
> +###########################
> +
> +# Time in seconds how long a user will be shown online
> +ONLINE_THRESHOLD = 60 * 30
> +# Number of stored users
> +ONLINE_MAX = 25
Does not match the numbers in online_users_middleware.py. Leave as is if this
is on purpose.
>
> try:
> from local_settings import *
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your team Widelands Developers is subscribed to branch lp:widelands-website.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
