Review: Approve
Changes look good to me. Two further diff comments, not sure about the first
one though.
Diff comments:
> === modified file 'data/campaigns/fri01.wmf/scripting/texts.lua'
> --- data/campaigns/fri01.wmf/scripting/texts.lua 2018-04-06 06:33:08
> +0000
> +++ data/campaigns/fri01.wmf/scripting/texts.lua 2018-05-06 06:35:33
> +0000
> @@ -138,13 +138,13 @@
> _([[This is as good a place as any to start building our new home.
> First of all, we must ensure a stable supply of basic building materials.]])
> .. paragraphdivider() ..
> -- TRANSLATORS: Reebaud – Introduction 2
> - _([[I have asked one of my advisors to oversee the construction of our
> settlement.]])),
> + _([[I have asked Hauke, one of my advisors to oversee the construction
> of our settlement.]])),
Isn´t a comma missing after "advisors"?
> }
> intro_3 = {
> title =_ "Introduction",
> body=hauke(_"The first buildings",
> -- TRANSLATORS: Hauke – Introduction 3
> - _([[Greetings, Chieftain Reebaud! I am Hauke, your First Advisor. I
> will start with the colonization of the island straight away.]])
> + _([[Greetings, Chieftain Reebaud! I will start with the colonization
> of the island straight away.]])
> .. paragraphdivider() ..
> -- TRANSLATORS: Hauke – Introduction 3
> _([[Like all Frisians, we build our houses mainly with bricks. We
> improve them by adding some logs and granite. The roofs are thatched with
> reed, naturally. Nothing is better suited to keep the rain out.]])
>
> === modified file 'data/campaigns/fri02.wmf/scripting/texts.lua'
> --- data/campaigns/fri02.wmf/scripting/texts.lua 2018-03-18 19:48:31
> +0000
> +++ data/campaigns/fri02.wmf/scripting/texts.lua 2018-05-06 06:35:33
> +0000
> @@ -325,7 +326,7 @@
> supply_murilius_thanks = {
> title =_ "The Empire is Grateful",
> -- TRANSLATORS: "Greetings, friend of the Empire!". DO NOT TRANSLATE.
> Reebaud doesn’t understand Latin. You can transliterate into non-Latin
> scripts though
Translators hint: friend → friends (same below)
> - body=murilius(_"Salve amicus Imperii!",
> + body=murilius(_"Salvete amici Imperii!",
> -- TRANSLATORS: Murilius – Supplied Murilius
> _([[Strangers! I see you have kept your word. The Empire rewards its
> friends, therefore I shall reward you with the friendship of the Empire!]])
> .. paragraphdivider() ..
--
https://code.launchpad.net/~widelands-dev/widelands/frisian-campaign-string-fixes/+merge/345136
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/frisian-campaign-string-fixes.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
