Thanks for implementing the comments. I just noticed another one: we prefer std::string over const char*. Parameters and return types then are const std::string&.
Diff comments: > > === modified file 'src/logic/message.h' > --- src/logic/message.h 2018-04-07 16:59:00 +0000 > +++ src/logic/message.h 2018-07-26 11:25:26 +0000 > @@ -72,8 +69,10 @@ > const std::string& init_body, > const Widelands::Coords& c = Coords::null(), > Widelands::Serial ser = 0, > + const char* subt = nullptr, Make this a const std::string. Checks can then be for sub_type_.empty() > Status s = Status::kNew) > : type_(msgtype), > + sub_type_(subt), > title_(init_title), > icon_filename_(init_icon_filename), > icon_(g_gr->images().get(init_icon_filename)), -- https://code.launchpad.net/~widelands-dev/widelands/no-hardcoded-resources/+merge/350750 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/no-hardcoded-resources into lp:widelands. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
