Notabilis has proposed merging
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands.
Commit message:
Fixing broken auto-scrolling of multi-line text areas.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1785404 in widelands: "Chat does not autoscroll"
https://bugs.launchpad.net/widelands/+bug/1785404
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
Seems to be a case of wrong direction of comparison. I would appreciate it if
someone thinks about it for a moment before merging.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands.
=== modified file 'src/ui_basic/multilinetextarea.cc'
--- src/ui_basic/multilinetextarea.cc 2018-07-28 07:02:25 +0000
+++ src/ui_basic/multilinetextarea.cc 2018-08-12 16:43:10 +0000
@@ -104,7 +104,7 @@
scrollbar_.set_steps(height - get_h());
if (scrollmode_ == ScrollMode::kScrollLog || scrollmode_ == ScrollMode::kScrollLogForced) {
- if (scrollbar_.get_scrollpos() >= scrollbar_.get_steps() - 1) {
+ if (scrollbar_.get_scrollpos() < scrollbar_.get_steps() - 1) {
scrollbar_.set_scrollpos(height - get_h());
}
}
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
